fix: handle 0 sized collector batches in PostOffice #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems this can happen when a message is sent with the duplicate flag, but the original message was successfully sent to all subscribed clients. In this case the The other way this can happen is if a dup message is sent, but all failed clients have since un-subscribed from the topic. In this case filterClients is not empty, but there are no matches between the subscription list and the filterClients Set. Your fix looks good to me. |
|
oh,,,It's happened on my application. |
RotherStefan
pushed a commit
to smart2i/moquette
that referenced
this pull request
Feb 15, 2024
This change is attempting to resolve moquette-io#750 where the call to retain is 0 and therefore countBatches must have returned 0. I know that this change will absolutely avoid the error, however, I'm not clear on why the number of batches would be 0 while this code is running. In this change, I simply treat it exactly the same as the above case where there are no subscriptions (and thus no work to do). (cherry picked from commit 8ab1c91)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is attempting to resolve #750 where the call to
retainis 0 and thereforecountBatchesmust have returned 0. I know that this change will absolutely avoid the error, however, I'm not clear on why the number of batches would be 0 while this code is running. In this change, I simply treat it exactly the same as the above case where there are no subscriptions (and thus no work to do).