Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates retained messages management to hanbdle message expiry interval #819

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

andsel
Copy link
Collaborator

@andsel andsel commented Feb 18, 2024

Release notes

Implements the management of message expiry for retained part.

What does this PR do?

Update retained messages handling to store and retrieve the message expiry property if present in publish.

  • updates retained persistence store, list and retrieve the expiry
  • updated PostOffice to track and untrack retained messages that has to be wipe. A new instance of ScheduledExpirationService is reserved for this.
  • during push of retained recalculate the message expiry interval

Why is it important/What is the impact to the user?

Implements message expiry feature for retained messages aspect.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the Changelog if it's a feature or a fix that has to be reported

Related issues

…eduledExpirationService to periodically clean the reatined storage
@andsel andsel self-assigned this Feb 18, 2024
@andsel andsel changed the title Updated retaind storage to keep also the expiry if present. Added Sch… Updates retained messages management to hanbdle message expiry interval Feb 18, 2024
@andsel andsel merged commit 23c7b39 into moquette-io:main Feb 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant