Reduced memory use on Sessions by removing handled items from inflightTimeouts #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andsel
requested changes
Apr 30, 2024
| @@ -343,6 +345,7 @@ private boolean inflightHasSlotsAndConnectionIsUp() { | |||
|
|
|||
| void pubAckReceived(int ackPacketId) { | |||
| // TODO remain to invoke in somehow m_interceptor.notifyMessageAcknowledged | |||
| inflightTimeouts.removeIf(d -> d.packetId == ackPacketId); | |||
There was a problem hiding this comment.
Please extract this on a method such as cleanFromInflight
private void cleanFromInflight(int packetId) {
inflightTimeouts.removeIf(d -> d.packetId == packetId);
} There was a problem hiding this comment.
Wasn't sure which form you'd prefer, since it was only one line.
Commit Updated.
…flightTimeouts Items in the inflightTimeouts DelayQueue were only ever removed when they timed out. But in normal operation the related messages would have been handled long before that. There should only ever be a number equal to the number of inflightSlots in the queue, but the queue would grow to the maximum number of messages ever handled in a 5 second interval. This made each session take much more memory than needed.
hylkevds
force-pushed
the
fix_inflightTimeouts
branch
from
3ac2c8f
to
862812b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced memory use on busy Sessions by removing handled items from inflightTimeouts
Items in the inflightTimeouts DelayQueue were only ever removed when they timed out. But in normal operation the related messages would have been handled long before that. There should only ever be a number equal to the number of inflightSlots in the queue, but the queue would grow to the maximum number of messages ever handled in a 5 second interval. This made each session take much more memory than needed.