Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased timeout to fix build failure on slow GitHub build systems #843

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

hylkevds
Copy link
Collaborator

Builds are sometimes failing on the GH build systems due to a timeout. This PR increases those timeouts from 200ms to 300 ms and puts the actual value of the timeouts in a constant for easier access.

Copy link
Collaborator

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, just a suggestion on the constant to transform in a Duration which is more explicit express what is it.

broker/src/test/java/io/moquette/testclient/Client.java Outdated Show resolved Hide resolved
broker/src/test/java/io/moquette/testclient/Client.java Outdated Show resolved Hide resolved
@hylkevds
Copy link
Collaborator Author

This is fine, just a suggestion on the constant to transform in a Duration which is more explicit express what is it.

Good idea!
I did change a few int parameters to long, to avoid casting.
It's a pity that CountDownLatch.await() doesn't accept a Duration, that would have been even cleaner :)

@andsel andsel self-requested a review June 20, 2024 16:12
Copy link
Collaborator

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andsel andsel merged commit 718b4fa into moquette-io:main Jun 20, 2024
3 of 4 checks passed
@hylkevds hylkevds deleted the fixTestTimeout branch August 25, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants