Implements management of receive_maximum parallel publishes the broekr can handle per client
#852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s class io.moquette.integration.mqtt5.TestUtils
Abstracts quota management in specialised classes (LimitedQuota and UnlimitedQuota) Server's receives quota is a volatile attribute of the client's connection and is valued at connection time. The value is defined in broker configuration, named `receive_maximum`.
andsel
force-pushed
the
feature/flow_control
branch
from
361caff
to
18d5c0b
Compare
andsel
changed the title
receive_maximum parallel publishes the broekr can handle per client
andsel
force-pushed
the
feature/flow_control
branch
from
c086bbb
to
188167c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Flow-control: implemented publish's quota management on the server side.
What does this PR do?
Update QoS1 and QoS2 management, at
MQTTConnectionlevel to handle the quota of parallel publishes that the broker receives from a client.Updates the config classes to store and retrieve the value of
receive_maximumsetting, and use that value inCONNACKto the client. When the quota is consumed, on next publish of QoS1 and QoS2 the broker sends a DISCONNECT with 0x93 error code and close the connection.Why is it important/What is the impact to the user?
Permit to the server to impose and respect a maximum parallel publishes it can handle per client, configurable in broker settings file. When the limit is passed it disconnects the client.
Checklist
[ ] I have made corresponding changes to the documentationAuthor's Checklist
How to test this PR locally
Related issues