Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed anidb refiner special episode without offset #2736

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

anderson-oki
Copy link
Collaborator

@anderson-oki anderson-oki commented Oct 25, 2024

Description

There are records of special episode types that are supposed to be using the the special tvdb season but they don't contain any mapping and use absolute episode numberings that fails with (cannot access local variable 'anidb_id' where it is not associated with a value) trying to get video information for this file:

The anidb_id does not depend of the mappings and can be moved outside of the if statement. Also the offset should be set to 0 if the mappings are not present.

 <anime anidbid="2766" tvdbid="76113" defaulttvdbseason="a">
    <name>Yuu Gi Ou: Duel Monsters GX</name>
  </anime>
 <anime anidbid="2908" tvdbid="72858" defaulttvdbseason="a">
    <name>Monster Farm: Enbanseki no Himitsu</name>
  </anime>
<anime anidbid="3626" tvdbid="286895" defaulttvdbseason="a">
    <name>Nintama Rantarou</name>
  </anime>

@anderson-oki anderson-oki reopened this Oct 25, 2024
@anderson-oki anderson-oki changed the base branch from master to development October 25, 2024 13:52
@anderson-oki anderson-oki changed the title Fixed anidb refiner special episode without mapping Fixed anidb refiner special episode without offset Oct 25, 2024
@anderson-oki anderson-oki self-assigned this Oct 25, 2024
@ThisIsntTheWay
Copy link
Contributor

LGTM 👍

@anderson-oki anderson-oki merged commit 23c19db into development Oct 26, 2024
@anderson-oki anderson-oki deleted the fix/anidb-refiner-special-single-mapping branch October 26, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants