-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add owner #43
Add owner #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB: Blue does not even need an owner now, so we might temporize a little bit this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it lacks some testing
Yes that's why I wrote:
|
The last 2 commits are not verified, I need to fix that EDIT: done |
I would like to see an alternative version, that's included in Blue.sol directly (similar to UniV3) |
Example in #67 |
I have several questions/thoughts:
dependencies
folder?Ownable
(orOwned
) orOwnable2Step
#15 I would lean toward the simplest way of doing this but it's debtablemsg.sender
as owner so that it can easily be deployed by a deployer contract using CREATE2 without transferring the ownership.Depending on the answer of the above questions I can move forward with the related features requiring an owner (#41, #29)