Write output with explicit UTF-8 encoding #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default encoding is platform-dependent, which is a problem on Windows specifically. Python 3.15 hopefully fixes this issue: https://peps.python.org/pep-0686/
|
CI failures seem to be related to Vulkan header stuff, most likely(?) unrelated to the output encoding. |
|
Thank you! And sorry that things didn't "just work" 😅 Yep, those errors are caused by regular updates to Vulkan headers. I'll look into that -- I don't have scheduled builds set up on the CI here so I only discover those too late. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows the encoding seems to default to one of the 8-bit code pages instead of UTF-8, noticable with special characters in the header. Python 3.15 supposedly will force the default to be UTF-8 on all platforms, but that's a long way off and won't help on older versions.