Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/ports moveit 3522 (backport #3070) #3074

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 8, 2024

Description

Ports moveit/moveit#3522 to moveit2. Should fix #2857

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference (fixes bug)
  • Document API changes relevant to the user in the MIGRATION.md notes (fixes bug)
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI (No GUI changes)
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3070 done by [Mergify](https://mergify.com).

rr-tom-noble and others added 2 commits November 8, 2024 19:07
* Makes PTP changes

* Makes LIN changes

* Makes CIRC changes

* Makes CIRC changes

* Makes CIRC changes

* Makes CIRC changes

* Makes LIN changes

* Makes LIN changes

* Fixes formatting

* Replace ROS_WARN with RCLCPP_WARN

* Fixes formatting

* Fixes RCLCPP_WARN calls

* Fixes compiler errors

* Fixes if statement

* Fixes formatting

* Fixes msg type

(cherry picked from commit 4c28a74)
@sea-bass sea-bass requested a review from sjahr November 11, 2024 02:20
@rr-tom-noble
Copy link
Contributor

@sjahr Would you mind taking a look at this when you get a chance? Thanks!

@rr-tom-noble
Copy link
Contributor

@sjahr I think this test failure is unrelated as the PlanningSceneMonitor has not been touched. Would it be possible to rerun the workflows?

@sea-bass
Copy link
Contributor

sea-bass commented Nov 13, 2024

@sjahr I think this test failure is unrelated as the PlanningSceneMonitor has not been touched. Would it be possible to rerun the workflows?

This has happened on the first CI job for every new PR that's come into humble. I suspect it's because the Humble cache source is out of date until #3082 lands and finally fixes/is able to push the Humble Docker image.

@sea-bass sea-bass merged commit 7132ddd into humble Nov 13, 2024
5 checks passed
@sea-bass sea-bass deleted the mergify/bp/humble/pr-3070 branch November 13, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants