Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Humble and Iron from tutorial Docker CI job #3081

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Nov 11, 2024

Description

These jobs have been failing as optional for a while, and the main branch of moveit2 just will not work with these older tutorial versions. So I opt for removing them here.

If anything, the tutorial job should be added into the humble branch to test that specific pipeline -- doing in #3082.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@rr-tom-noble
Copy link
Contributor

Thanks for doing this! Those failing workflows have been irking me in recent PRs 😅

Happy to close #3078 with this

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't plan to make them working, these should be removed here. I agree.

@sea-bass
Copy link
Contributor Author

If you don't plan to make them working, these should be removed here. I agree.

I am moving the job for Humble to the humble branch in #3082

As for Iron? The tutorials haven't really worked on that version for a while (there isn't even an iron branch in the moveit2_tutorials repo), and it's been so long that Iron is almost EOL. 😢

@sea-bass sea-bass added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 2490e51 Nov 11, 2024
11 of 12 checks passed
@sea-bass sea-bass deleted the remove-humble-iron-tutorial-docker-ci branch November 11, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants