Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attached Collision Object Transparency #3093

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

rr-aiden
Copy link
Contributor

@rr-aiden rr-aiden commented Nov 15, 2024

Description

This PR aims to resolve missing functionality from Moveit1 which allowed for attached collision objects to become transparent through the setting of an alpha value in robot_state_visualization.cpp. It also defaults the alpha value to match the Scene Robot Alpha value which was default behaviour for Moveit1.

If this could be backported to Humble it would be much appreciated

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@rr-aiden rr-aiden changed the title Collision object transparency Attached Collision Object Transparency Nov 15, 2024
Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@sjahr sjahr added backport-humble Mergify label that triggers a PR backport to Humble backport-iron Mergify label that triggers a PR backport to Iron labels Nov 15, 2024
@sjahr sjahr enabled auto-merge November 15, 2024 11:20
@sjahr sjahr added this pull request to the merge queue Nov 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2024
@rr-tom-noble
Copy link
Contributor

rr-tom-noble commented Nov 15, 2024

@rr-aiden Ah my failing tests broke your merge queue jobs 😅

Should be good with #3095

@sjahr sjahr enabled auto-merge November 15, 2024 13:40
@sjahr sjahr added this pull request to the merge queue Nov 15, 2024
Merged via the queue into moveit:main with commit 1944811 Nov 15, 2024
11 checks passed
mergify bot pushed a commit that referenced this pull request Nov 15, 2024
* Allows attached collision objects to be transparent

* Allows for config/RViz driven changing of the attached collision object transparency

---------

Co-authored-by: Sebastian Jahr <[email protected]>
(cherry picked from commit 1944811)
mergify bot pushed a commit that referenced this pull request Nov 15, 2024
* Allows attached collision objects to be transparent

* Allows for config/RViz driven changing of the attached collision object transparency

---------

Co-authored-by: Sebastian Jahr <[email protected]>
(cherry picked from commit 1944811)
sea-bass pushed a commit that referenced this pull request Nov 15, 2024
* Allows attached collision objects to be transparent

* Allows for config/RViz driven changing of the attached collision object transparency

---------

Co-authored-by: Sebastian Jahr <[email protected]>
(cherry picked from commit 1944811)

Co-authored-by: Aiden <[email protected]>
sea-bass pushed a commit that referenced this pull request Nov 16, 2024
* Allows attached collision objects to be transparent

* Allows for config/RViz driven changing of the attached collision object transparency

---------

Co-authored-by: Sebastian Jahr <[email protected]>
(cherry picked from commit 1944811)

Co-authored-by: Aiden <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble backport-iron Mergify label that triggers a PR backport to Iron
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants