-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: OctoMap and Filtered_Cloud Not Updating During Movement Execution (backport #3209) #3211
Conversation
#3209) * fix: adds MutuallyExclusive to pointcloud subscriber to allow octomap updates during motion * refactor: adjust macro for readability (cherry picked from commit 246aa58) # Conflicts: # moveit_ros/perception/pointcloud_octomap_updater/include/moveit/pointcloud_octomap_updater/pointcloud_octomap_updater.hpp # moveit_ros/perception/pointcloud_octomap_updater/src/pointcloud_octomap_updater.cpp
Cherry-pick of 246aa58 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
b1adae1
to
b14508a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## humble #3211 +/- ##
==========================================
- Coverage 51.40% 51.40% -0.00%
==========================================
Files 382 382
Lines 31893 31893
==========================================
- Hits 16393 16392 -1
- Misses 15500 15501 +1 ☔ View full report in Codecov by Sentry. |
Description
MutuallyExclusive callbackgroup has been added to
point_cloud_subscriber_
to allow updating octomap during robot motion. See #2192Additional notes
I was not able to do the same fix to the
depth_image_octomap_updater
sinceimage_transport::create_camera_subscription
seems to not allow passingSubscriptionOptions
.I noticed that there is a big computational time mismatch between the two approaches (depth/pointcloud). After digging in a bit i found that the main computational time difference comes from
lazy_free_space_updater
but unfortunately I have not time to fix it. I will use the pointcloud instead._This is an automatic backport of pull request #3209 done by [Mergify](https://mergify.com).