Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing target dependencies to eigen_stl_containers (backport #3295) #3296

Merged
merged 2 commits into from
Feb 2, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 1, 2025

Description

I was doing a "build on potato computer" build of MoveIt 2 with -j 4 and --executor sequential, and found myself with some errors related to missing eigen_stl_containers headers.

Turns out there has been a missing target dependency in these targets that use the library? Not sure how others haven't run into this, or whether some upstream dependency recently removed this transitively?

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3295 done by [Mergify](https://mergify.com).

Sorry, something went wrong.

* Add missing target dependencies to eigen_stl_containers

* Another one

(cherry picked from commit d88d19f)

# Conflicts:
#	moveit_core/collision_detection/CMakeLists.txt
#	moveit_core/robot_state/CMakeLists.txt
@mergify mergify bot added the conflicts label Feb 1, 2025
Copy link
Author

mergify bot commented Feb 1, 2025

Cherry-pick of d88d19f has failed:

On branch mergify/bp/humble/pr-3295
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit d88d19fb2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   moveit_core/distance_field/CMakeLists.txt
	modified:   moveit_core/robot_model/CMakeLists.txt

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   moveit_core/collision_detection/CMakeLists.txt
	both modified:   moveit_core/robot_state/CMakeLists.txt

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@sea-bass sea-bass mentioned this pull request Feb 2, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.40%. Comparing base (343b897) to head (996151b).
Report is 2 commits behind head on humble.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #3296      +/-   ##
==========================================
- Coverage   51.41%   51.40%   -0.00%     
==========================================
  Files         382      382              
  Lines       31894    31899       +5     
==========================================
  Hits        16395    16395              
- Misses      15499    15504       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass merged commit c0f8742 into humble Feb 2, 2025
7 checks passed
@sea-bass sea-bass deleted the mergify/bp/humble/pr-3295 branch February 2, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants