Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing target dependencies to eigen_stl_containers (backport #3295) #3297

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 1, 2025

Description

I was doing a "build on potato computer" build of MoveIt 2 with -j 4 and --executor sequential, and found myself with some errors related to missing eigen_stl_containers headers.

Turns out there has been a missing target dependency in these targets that use the library? Not sure how others haven't run into this, or whether some upstream dependency recently removed this transitively?

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3295 done by [Mergify](https://mergify.com).

* Add missing target dependencies to eigen_stl_containers

* Another one

(cherry picked from commit d88d19f)
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.12%. Comparing base (e6be7dc) to head (73e0fe7).
Report is 1 commits behind head on jazzy.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #3297      +/-   ##
==========================================
- Coverage   44.12%   44.12%   -0.00%     
==========================================
  Files         700      700              
  Lines       61666    61667       +1     
  Branches     7473     7473              
==========================================
- Hits        27207    27205       -2     
- Misses      34291    34294       +3     
  Partials      168      168              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass merged commit 291d159 into jazzy Feb 1, 2025
7 checks passed
@sea-bass sea-bass deleted the mergify/bp/jazzy/pr-3295 branch February 1, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants