Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency exports and update to .hpp includes #66

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Fix dependency exports and update to .hpp includes #66

merged 1 commit into from
Feb 3, 2025

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Feb 1, 2025 •
edited
Loading

This PR does a few things:

  1. Fixes the ament_export_dependencies per Unsure how to modify CMakeLists.txt to use moveit_drake #65
  2. Updates MoveIt 2 header includes to .hpp to prevent deprecation warnings
  3. Updates the header include from the generated KTOpt parameters to match the new generate_parameter_library 0.4.0 behavior

Closes #65

@sea-bass sea-bass requested review from kamiradi and sjahr February 1, 2025 21:29
@sea-bass sea-bass mentioned this pull request Feb 1, 2025
Closed
kamiradi
kamiradi approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@kamiradi kamiradi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @sea-bass.

@kamiradi kamiradi merged commit 047dfd3 into main Feb 3, 2025
2 checks passed
@kamiradi kamiradi deleted the hpp-and-fix-export branch February 3, 2025 09:55
@sjahr
Copy link
Contributor

sjahr commented Feb 3, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamiradi kamiradi kamiradi approved these changes

@sjahr sjahr Awaiting requested review from sjahr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsure how to modify CMakeLists.txt to use moveit_drake
3 participants
@sea-bass @sjahr @kamiradi