Fix SQL column name escaping #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gleichdick
force-pushed
the
fix_absent_columns_ros2
branch
from
4cb4b85 to
4e0e247
Compare
Using double quotes had the disadvantage that unknown column names were silently changed to a string literal in WHERE statements. This can be avoided by using backticks. Fixes moveit#43
gleichdick
force-pushed
the
fix_absent_columns_ros2
branch
from
4e0e247 to
d7fb4b7
Compare
rhaschke
approved these changes
Aug 6, 2024
rhaschke
pushed a commit
that referenced
this pull request
Aug 6, 2024
* Add test for appendGTE and friends. * Use backticks to quote SQL identifiers Using double quotes had the disadvantage that unknown column names were silently changed to a string literal in WHERE statements. This can be avoided by using backticks.
|
@henningkayser, I wanted to release this repo, but I can't push the release version and tag due to branch protection rules. |
|
rolling: ros/rosdistro#42416 |
|
I don't think so. Thanks Robert! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using double quotes had the disadvantage that unknown
column names were silently changed to a string literal
in WHERE statements. This can be avoided by using backticks.
Can I ask someone with a ROS2 toolchain to test this PR? And to make a new release (1.0.4)?
Fixes #43