Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix black-on-black text color issues #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toastal
Copy link

@toastal toastal commented Nov 23, 2021

Using Firefox with a dark GTK theme, I sometimes run into issues where the author has not set a default background and foreground color. When later in the stylesheet a color is chosen (often black) and a background is not specified (under an assumption that all user agents are running white backgrounds), you will end up with black-on-black text which is obviously quite difficult to read. The solution is to set a background and color on the document.

Using Firefox with a dark GTK theme, I sometimes run into issues where the author has not set a default background and foreground color. When later in the stylesheet a color is chosen (often black) and a background is _not_ specified (under an assumption that all user agents are running white backgrounds), you will end up with black-on-black text which is obviously quite difficult to read. The solution is to set a background and color on the document.
@toastal
Copy link
Author

toastal commented Nov 23, 2021

black-on-black text

versus after

With a the applied change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant