Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #65: Update Relase Docs #84

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Conversation

matt-boris
Copy link
Contributor

@matt-boris matt-boris commented Nov 11, 2021

For #65

@matt-boris matt-boris marked this pull request as ready for review November 15, 2021 16:53
Copy link
Contributor

@grahamalama grahamalama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd lean on @leplatrem to ensure that we're not missing anything here, but this documentation seems pretty comprehensive to me 👍🏻.

Comment on lines +53 to +54
1. Bump version in `package.json`, `update.json` (has **three** version instances that need to be updated), and `extension/manifest.json`
2. Tag commit `git tag -a X.Y.Z` and push it `git push origin X.Y.Z`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would be worth abstracting this into a little convenience script so that instead of having to remember to update in 5 places, tag, then push, we run like scripts/generate_release.sh or something that. Not necessary for this PR, but if we find ourselves forgetting to update these values, maybe something we consider.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I like that! Just created #85

3. Click on the `release-signing-remote-settings-devtools` task
4. Click the `Artifacts` dropdown on the right side of the page
5. Download the artifact named `public/build/remote-settings-devtools.xpi` to your machine
6. Append `-X.Y.Z` to the end of the filename
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why the artifact is not named with the release name (remote-settings-devtools-X.Y.Z-build1)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was confused by this too... Wonder if it's worth bringing up to #addons-pipeline

Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌
Thanks Boris for putting this together 🙏

@matt-boris matt-boris merged commit e777ba0 into master Nov 15, 2021
@matt-boris matt-boris deleted the matt-boris/updateReleaseDocs branch November 15, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants