Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative implementation of the deployment-status action. #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smarnach
Copy link
Contributor

This is an alternative implementation of the deployment-status action. It should be backwards-compatible with the existing implementation except it doesn't support the command input and only updates the deployment status.

Advantages:

  • Allows setting the deployment_id to identify a pre-existing deployment.
  • Allows filtering deployment by sha in addition to ref and environment.
  • Sets the log_url for the deployment status to point to the workflow run, so the logs can easily be accessed from the application repo.
  • Suitable for running on the self-hosted runners, which don't have Docker installed.
  • Eliminates the need to pass in the installation id. It's figured out based on the org of the target repo.
  • Scopes the installation token to the targt repo.
  • Faster and somewhat simpler than the original implementation.

I'm not sure it's a suitable replacement for all use cases of the old action, and how to migrate to it if that's what you want to do. I would like to be able to use this action for the crash ingestion services, but we could also add it to this repository with a different name.

@smarnach smarnach requested a review from dlactin June 14, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants