Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moderator rds #126

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Moderator rds #126

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d92a0c1
updating the RDS cert for moderator prod
Basma1912 Jan 29, 2024
49e8ea3
updating the RDS cert for moderator-prod
Basma1912 Jan 29, 2024
13a992c
updating the RDS mysql engine for moderator-prod
Basma1912 Jan 29, 2024
0d02958
updating the RDS mysql engine for moderator-prod
Basma1912 Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion terraform/applications/moderator/mysql.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ resource "aws_db_instance" "moderator" {
max_allocated_storage = var.mysql_storage_max
multi_az = var.environment == "prod" ? true : false
allow_major_version_upgrade = true
name = var.project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need the name anymore?

Copy link
Contributor Author

@Basma1912 Basma1912 Jan 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkochendorfer yes - the name argument was deprecated
│ on mysql.tf line 36, in resource "aws_db_instance" "moderator":
│ 36: name = var.project
│
│ An argument named "name" is not expected here.

username = var.project
backup_retention_period = 30
db_subnet_group_name = aws_db_subnet_group.moderator-db.id
vpc_security_group_ids = [aws_security_group.moderator-db.id]
apply_immediately = true
ca_cert_identifier = var.ca_cert_identifier
}
2 changes: 1 addition & 1 deletion terraform/applications/moderator/state.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws",
version = "~> 3.27"
version = "> 3.27"
}
}

Expand Down
6 changes: 6 additions & 0 deletions terraform/applications/moderator/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,9 @@ variable "region" {
default = "us-west-2"
type = string
}

variable "ca_cert_identifier" {
default = "rds-ca-rsa4096-g1"
description = "Allows you to modify the underlying RDS certificate"
}

2 changes: 1 addition & 1 deletion terraform/applications/moderator/variables.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ moderator_mozilla = "moderator.mozilla.org"
mysql_instance = "db.t3.micro"
mysql_storage_allocated = 5
mysql_storage_max = 20
mysql_version = "5.7"
mysql_version = "5.7.42"
project = "moderator"
project_desc = "moderator.mozilla.org"
project_email = "[email protected]"
Expand Down
Loading