Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete and empty files #56

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Remove obsolete and empty files #56

merged 1 commit into from
Feb 26, 2025

Conversation

flodolo
Copy link
Contributor

@flodolo flodolo commented Feb 26, 2025

This is pending confirmation that we have the build code in ESR115 to deal with missing files.

@flodolo flodolo requested a review from a team as a code owner February 26, 2025 12:43
@flodolo
Copy link
Contributor Author

flodolo commented Feb 26, 2025

This feels too large. I'm guessing it's also Pontoon adding them, because of the new sync code?

CC @eemeli

@flodolo
Copy link
Contributor Author

flodolo commented Feb 26, 2025

There are files that are obsolete (missing from the reference):

  • /browser/browser/firefoxWebAuthn.ftl
  • /toolkit/toolkit/global/mozCard.ftl
  • /toolkit/toolkit/global/timepicker.ftl
  • /toolkit/toolkit/reportBrokenSite/reportBrokenSite.ftl

Another file is obsolete for mobile:

  • /mobile/chrome/region.properties

The other are all files with just comments, either created by my previous script, or by Pontoon with the new sync.

One way to look at this diff is locally using the GitHub desktop app, as you can visually browse each commit.

Some commit, for locales that are very behind, are very large. Example, Xhosa: a76b22d

@eemeli
Copy link
Member

eemeli commented Feb 26, 2025

As we're still using the old build tooling for 115 and 128, we shouldn't remove yet the empty files that are helping them avoid fallback, but the obsolete files you list should be removable now as they're not used anywhere at all.

@flodolo flodolo marked this pull request as draft February 26, 2025 15:00
@flodolo flodolo force-pushed the cleanup_obsolete_files branch from 67e6855 to c286eed Compare February 26, 2025 15:15
@flodolo flodolo marked this pull request as ready for review February 26, 2025 15:17
@flodolo flodolo merged commit 49842c6 into main Feb 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants