Refactor EXP-3953 [v121] Move nimbus-fml.sh to application-services #16969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhugman
commented
Oct 23, 2023
| @@ -37,5 +37,9 @@ if [ "$1" == "--importLocales" ]; then | |||
| exit 0 | |||
| fi | |||
|
|
|||
| # Download the nimbus-fml.sh script from application-services. | |||
| NIMBUS_FML_FILE=./nimbus.fml.yaml | |||
There was a problem hiding this comment.
Should you ever move the nimbus.fml.yaml file, you should change this.
Generated by 🚫 Danger Swift against 4ca9cba |
lmarceau
reviewed
Oct 23, 2023
jhugman
force-pushed
the
jhugman/move-fml-script-to-as
branch
from
672788f
to
563e527
Compare
|
@jhugman let me re-run this PR so that it is unblocked to be merged when approved. Context: Bitrise is red because the UI Smoketest run isolated, not as part of the pipeline and failed because it misses the dependencies. |
|
Thank you @isabelrios ! |
|
This pull request has conflicts when rebasing. Could you fix it @jhugman? 🙏 |
jhugman
force-pushed
the
jhugman/move-fml-script-to-as
branch
from
563e527
to
4ca9cba
Compare
jhugman
had a problem deploying
to
github-pages
GitHub Actions
Failure
jhugman
had a problem deploying
to
github-pages
GitHub Actions
Failure
jhugman
changed the title
adudenamedruby
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
💡 Description
This moves the
nimbus-fml.shout of Firefox for iOS and into Application Services. The app services PR adds a bootstrap script which can be curled and executed as part of this project's bootstrap. This is now documented inexperimenter.infodocs.This has been a long held, low priority goal. The pricipitating events:
validatecommand to thenimbus-fmlcommand linevalidatecommand checks for the relevant metadata. These warnings are emitted in the Build console logs.messagingfeature.generate-experimentercommand is now being run by experimenter, so is no longer needed to be commited into the repository..experimenter.yamlfileOnce merged, engineers will need to re-run the
bootstrap.shscript on their machines to re-download thenimbus-fml.shscript (it is removed, and added to.gitignorein this PR).This should otherwise provide no extra functionality or tests.
Commits:
📝 Checklist
You have to check all boxes before merging