Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FXIOS-9761 Verify text color of location text field #21545

Merged

Conversation

thatswinnie
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Sets the tint color for the text field. Uses the text color in edit mode (in non-edit mode the url gets formatted). Updates the selected text color for the dark theme. And updates the tint of the clear button when changing themes.

Simulator Screen Recording - iPhone 15 Pro Max - 2024-08-16 at 17 24 42

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@mobiletest-ci-bot
Copy link

Messages
📖 Edited 3 files
📖 Created 0 files

Generated by 🚫 Danger Swift against d042cd0

@thatswinnie thatswinnie requested review from cyndichin and removed request for adudenamedruby August 21, 2024 14:50
Copy link
Contributor

@cyndichin cyndichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! how does it look in private theme? Do we need to update any colors for that?

@thatswinnie
Copy link
Contributor Author

looks good! how does it look in private theme? Do we need to update any colors for that?

@cyndichin private mode is shown in the gif as well. The colors that are used in this PR were discussed with design in person during MozWeek. No further updates are necessary.

@thatswinnie thatswinnie merged commit b1cc6ab into main Aug 22, 2024
13 of 14 checks passed
@thatswinnie thatswinnie deleted the wt/FXIOS-9761-Verify-text-color-of-location-text-field branch August 22, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants