-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor FXIOS-9761 Verify text color of location text field #21545
Refactor FXIOS-9761 Verify text color of location text field #21545
Conversation
…text-color-of-location-text-field
Generated by 🚫 Danger Swift against d042cd0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! how does it look in private theme? Do we need to update any colors for that?
@cyndichin private mode is shown in the gif as well. The colors that are used in this PR were discussed with design in person during MozWeek. No further updates are necessary. |
📜 Tickets
Jira ticket
Github issue
💡 Description
Sets the tint color for the text field. Uses the text color in edit mode (in non-edit mode the url gets formatted). Updates the selected text color for the dark theme. And updates the tint of the clear button when changing themes.
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)