Refactor FXIOS improve build times #22424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 7, 2024 14:43
…lient Metrics.swift output directory to Generated/Metrics to avoid glean removing nimbus generated files
Generated by 🚫 Danger Swift against 263cd65 |
|
This pull request has conflicts when rebasing. Could you fix it @FilippoZazzeroni? 🙏 |
FilippoZazzeroni
had a problem deploying
to
github-pages
GitHub Actions
Failure
|
This pull request has conflicts when rebasing. Could you fix it @FilippoZazzeroni? 🙏 |
nbhasin2
approved these changes
Oct 11, 2024
FilippoZazzeroni
had a problem deploying
to
github-pages
GitHub Actions
Failure
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Improve build times according to the provided document.
results.pdf
@nbhasin2 i changed the output folder for the Generated Metrics file for Client, to Generated/Metrics/Metrics.swift. That because running script in parallel was deleting previously generated Nimbus files. Do you think is this going to cause some side effects ? I didn't find a way to tell Glean to remove just the Metrics file, this could be optimal too.
To the solution i added also skips dsym creation symbols from
FennecandFennec_Testingconfig, is it something that was required ?📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)