Bugfix FXIOS-10832 Possible workaround for FXIOS-10832 withCheckedContinuation crash in JumpBackInDataAdaptor #23678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or the hasAccount() call and cleaning up some weird code.
Client.app: Coverage: 31.95
CredentialProvider.appex: Coverage: 21.18
NotificationService.appex: Coverage: 26.01
ShareTo.appex: Coverage: 31.57
libAccount.a: Coverage: 31.14
Generated by 🚫 Danger Swift against 6ee5122 |
|
Please review carefully @adudenamedruby and @nbhasin2 for sanity's sake... I wasn't sure the test path for this code and it was very weird. 😕 |
lmarceau
previously requested changes
Dec 10, 2024
firefox-ios/Client/Frontend/Home/JumpBackIn/Data/JumpBackInDataAdaptor.swift
Show resolved
Hide resolved
adudenamedruby
approved these changes
Dec 11, 2024
nbhasin2
approved these changes
Dec 11, 2024
I'm adding QA notes to the ticket for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
This is to fix the Sentry crash linked in the bug description related to JumpBackInDataAdaptor.
You'll notice that the Rust code is very... weird. It's strangely making a synchronous call asynchronous (completely unnecessary), and there's also a synchronous version already right underneath it...
By cleaning that up we can remove the
withCheckedContinuationon line 128 ofJumpBackInDataAdaptorwhere we were crashing, so this will hopefully fix that issue. 🤞📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)