Bugfix FXIOS-10149, FXIOS-10940 Migrate to Kingfisher 8 and fix iOS 18 crash on launch (continuations again?) #23920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unnecessary timeout code. Remove continuation.
ih-codes
commented
Dec 20, 2024
| @@ -49,42 +49,24 @@ final class FaviconFetcherTests: XCTestCase { | |||
| XCTFail("Should have succeeded with image") | |||
| } | |||
| } | |||
|
|
|||
| func testTimeout_completesWithoutImageOrError() async { | |||
There was a problem hiding this comment.
This test didn't make sense anymore because we're using Kingfisher's timeout functionality.
nbhasin2
reviewed
Dec 20, 2024
| return result | ||
| // Override Kingfisher's default timeout (which is 15s) | ||
| let modifier = AnyModifier { request in | ||
| var r = request |
There was a problem hiding this comment.
nit: could we make these more verbose please (instead of one letter)
There was a problem hiding this comment.
Oops yep, I'll push that up, that was a copy & paste from the Kingfisher docs.
Generated by 🚫 Danger Swift against 9b78579 |
nbhasin2
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira Kingfisher Upgrade
Github Kingfisher Upgrade
FXIOS-10940 Crash
Github Crash
💡 Description
This PR upgrades Kingfisher to version 8 and removes continuations related to downloadImage for favicons in favor of leveraging the async/await versions.
Kingfisher has a built in timeout so I deleted timeout-related code and ensured we were setting the timeout modifier on our kingfisher downloadImage request.
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)