Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FXIOS-10897 [Bookmarks Evolution] Remove Deferred usage from BookmarksSaver #23970

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

PARAIPAN9
Copy link
Collaborator

@PARAIPAN9 PARAIPAN9 commented Dec 30, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Replace Deferred with Result type completion handler.
  • Tests Pass

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@PARAIPAN9 PARAIPAN9 requested a review from a team as a code owner December 30, 2024 12:24
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 34.46%
📖 Edited 4 files
📖 Created 0 files

Client.app: Coverage: 32.5

File Coverage
BookmarksSaver.swift 95.72%

libStorage.a: Coverage: 56.87

File Coverage
RustPlaces.swift 81.29%

Generated by 🚫 Danger Swift against 20f9ae7

@lmarceau
Copy link
Contributor

lmarceau commented Jan 6, 2025

@PARAIPAN9 I think there was a new function added in BookmarksSaver called restoreBookmarkNode. We should remove Deferred from there as well. Could you have a look? 🙏

@MattLichtenstein MattLichtenstein changed the title Refactor FXIOS-10897 - Remove Deferred usage from BookmarksSaver Refactor FXIOS-10897 [Bookmarks Evolution] Remove Deferred usage from BookmarksSaver Jan 7, 2025
Copy link
Contributor

mergify bot commented Jan 7, 2025

This pull request has conflicts when rebasing. Could you fix it @PARAIPAN9? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants