Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - auto update credential provider script #24029

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 8, 2025

Automated changes by create-pull-request GitHub action

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Jan 8, 2025

Messages
📖 Edited 11 files
📖 Created 0 files

Generated by 🚫 Danger Swift against d50dfe4

@github-actions github-actions bot force-pushed the update-cred-provider-script branch from 18012b1 to 71f1d24 Compare January 9, 2025 00:26
@isabelrios
Copy link
Contributor

@issammani there are consistent failures in this PR for three UI Tests:

  • testDeleteAddress: Timed out waiting for element "Addresses" NavigationBar
  • testAddNewAddressAllFieldsFilled: Navigation error from SettingsScreen to AutofillAddress
  • testAutofillCreditCardsToggleOnOff: Timed out waiting for element "KeyboardAccessory.creditCardAutofillButton"

there might be some change that requires either a fix or an update on those tests...

@github-actions github-actions bot force-pushed the update-cred-provider-script branch from 71f1d24 to 6f4588d Compare January 10, 2025 00:27
@issammani
Copy link
Collaborator

@issammani there are consistent failures in this PR for three UI Tests:

* testDeleteAddress: Timed out waiting for element "Addresses" NavigationBar

* testAddNewAddressAllFieldsFilled: Navigation error from SettingsScreen to AutofillAddress

* testAutofillCreditCardsToggleOnOff: Timed out waiting for element "KeyboardAccessory.creditCardAutofillButton"

there might be some change that requires either a fix or an update on those tests...

Sorry for the delayed response ( Still catching up from PTO). I can already see one thing that is wrong. Not sure if it's causing the issue though. I will take a look. Thanks.

@github-actions github-actions bot force-pushed the update-cred-provider-script branch 3 times, most recently from c523b70 to d50dfe4 Compare January 16, 2025 20:58
@github-actions github-actions bot requested a review from a team as a code owner January 16, 2025 20:58
@github-actions github-actions bot requested a review from AaronMT January 16, 2025 20:58
Copy link
Contributor

mergify bot commented Jan 16, 2025

⚠️ The sha of the head commit of this PR conflicts with #24185. Mergify cannot evaluate rules on this PR. ⚠️

@github-actions github-actions bot force-pushed the update-cred-provider-script branch from d50dfe4 to 2583cae Compare January 17, 2025 00:26
@github-actions github-actions bot force-pushed the update-cred-provider-script branch 2 times, most recently from 64e72c0 to 457396b Compare January 21, 2025 00:26
Copy link
Contributor

mergify bot commented Jan 21, 2025

⚠️ The sha of the head commit of this PR conflicts with #24185. Mergify cannot evaluate rules on this PR. ⚠️

@github-actions github-actions bot force-pushed the update-cred-provider-script branch from 457396b to 9393ec8 Compare January 22, 2025 00:26
@github-actions github-actions bot force-pushed the update-cred-provider-script branch from 9393ec8 to 0381bb9 Compare January 23, 2025 00:26
@issammani issammani closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants