Add FXIOS-11033 [Bookmarks Evolution] A11y button traits for tableview cells #24086
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
button
accessibility trait to tableview cells in the bookmarks panel, edit bookmark view (parent folder section), and edit folder view (parent folder section)📝 Discussion:
LegacyBookmarksPanel
implicitly because we were using the.disclosureIndicator
accessorType
, which automatically gave the cells thebutton
accessibility trait. Now that we use a customaccessoryView
in each of the cells in the table inBookmarksViewController
, we no longer need the.disclosureIndicator
accessoryType
, and instead use.none
button
trait never worked for the parent folder selector in theLegacyBookmarkDetailPanel
, so that has now been remedied in theEditBookmarkViewController
andEditFolderViewController
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)