Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-11033 [Bookmarks Evolution] A11y button traits for tableview cells #24086

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MattLichtenstein
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Add the button accessibility trait to tableview cells in the bookmarks panel, edit bookmark view (parent folder section), and edit folder view (parent folder section)

📝 Discussion:

  • This previously worked in the LegacyBookmarksPanel implicitly because we were using the .disclosureIndicator accessorType, which automatically gave the cells the button accessibility trait. Now that we use a custom accessoryView in each of the cells in the table in BookmarksViewController, we no longer need the .disclosureIndicator accessoryType, and instead use .none
  • The button trait never worked for the parent folder selector in the LegacyBookmarkDetailPanel, so that has now been remedied in the EditBookmarkViewController and EditFolderViewController

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@MattLichtenstein MattLichtenstein requested a review from a team as a code owner January 10, 2025 19:42
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 34.3%
📖 Edited 3 files
📖 Created 0 files

Client.app: Coverage: 32.39

File Coverage
EditBookmarkViewController.swift 37.41% ⚠️
BookmarksViewController.swift 8.67% ⚠️
EditFolderViewController.swift 43.05% ⚠️

Generated by 🚫 Danger Swift against 970401a

Copy link
Collaborator

@DanielDervishi DanielDervishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a try -- works as intended 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants