Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Fix missing buttons in Find In Page bar #3894

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

sryze
Copy link
Contributor

@sryze sryze commented Oct 25, 2023

  1. Move the corresponding icon assets to the DesginSystem module so that
    they can be found at runtime.

  2. When the user hasn't entered any text, the previous/next buttons were
    not made disabled, which could be a little bit misleading and was not
    consistent with the case where there are no search results.

Fixes #3699

@sryze sryze requested a review from a team as a code owner October 25, 2023 20:01
@sryze sryze changed the title Find in page buttons fix Fix missing buttons in Find In Page bar Oct 25, 2023
Copy link
Contributor

mergify bot commented Nov 21, 2023

This pull request has conflicts when rebasing. Can you please fix it @sryze? 🙏

1 similar comment
Copy link
Contributor

mergify bot commented Feb 5, 2024

This pull request has conflicts when rebasing. Can you please fix it @sryze? 🙏

Move the corresponding icon assets to the DesginSystem module so that
they can be found at runtime.

Fixes mozilla-mobile#3699
When the user hasn't entered any text, the previous/next buttons were
not made disabled, which could be a little bit misleading and was not
consistent with the case where there are no search results.
@sryze sryze force-pushed the find-in-page-buttons-fix branch 2 times, most recently from b06d910 to aac944d Compare February 9, 2024 16:51
@sryze
Copy link
Contributor Author

sryze commented Feb 9, 2024

Rebased

@isabelrios isabelrios merged commit cb89e40 into mozilla-mobile:main Mar 4, 2024
6 checks passed
isabelrios added a commit to isabelrios/firefox-ios that referenced this pull request Mar 4, 2024
…ocus-ios#3894)

* Fix invisible Find Previous & Find Next buttons

Move the corresponding icon assets to the DesginSystem module so that
they can be found at runtime.

Fixes mozilla-mobile/focus-ios#3699

* Make Find Previous / Find Next buttons initially disabled

When the user hasn't entered any text, the previous/next buttons were
not made disabled, which could be a little bit misleading and was not
consistent with the case where there are no search results.

---------

Co-authored-by: isabelrios <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find in Page is worthless
3 participants