Linux allow mixing tunnelled and vpn containers #6695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cimbali
changed the title
Cimbali
force-pushed
the
linux-allow-tunnel-and-vpn-containers
branch
4 times, most recently
from
ae4d1f0 to
4ce6480
Compare
|
Cimbali
force-pushed
the
linux-allow-tunnel-and-vpn-containers
branch
from
4ce6480 to
a058460
Compare
|
Rebased to handle conflicts from whitespace changes in 7229a3f. |
Use 10.124.0.0/20 as documented in the code
Cimbali
force-pushed
the
linux-allow-tunnel-and-vpn-containers
branch
from
a058460 to
8d8d07b
Compare
|
Hey! Sorry for the late review for this - it dropped through the crack, if that happens again always feel free to either The code looks great, no comments there but this is not the direction we decided to take to allow a selective bypass - there is currently in flight work to provide a localhost proxy only firefox can access, which will provide a non vpn route (on both windows and linux) . See: https://github.com/mozilla-mobile/mozilla-vpn-client/tree/main/extension/socks5proxy/ Plan is to get that out either v2.25 or v2.26 - at which point mac out also be able to access that :) |
|
Thanks, I’ll keep an eye out for when that’s merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes allow to take split-tunnel as requested in e.g. mozilla/multi-account-containers#2259
The effect of this PR is to allow mixing non-VPN tabs and VPN tabs in Firefox:
socks://10.64.0.1:1080, tabs access the internet through the VPN location used for the connectionIn short, this is done by preventing the socks5 proxies used by mozillavpn/wireguard to be added to the split-tunnelling rules.
Changes are very lightweight (though only for Linux in this PR), and only affect private ranges of addresses (10.x). This means no side-effects even in the unlikely chance of users using the same range if IP addresses as mullvad in their LAN, as local routing rules are always checked before VPN routing (in which case the socks proxies are never reachable to start with).
Reference
mozilla/multi-account-containers#2259
Checklist