Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update detekt to version 1.23.1 #2435

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Update detekt to version 1.23.1 #2435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30ffb06
Update detekt to version 1.23.1 and synchronize config with firefox-a…
rvandermeulen Aug 15, 2023
16517db
Merge branch 'master' into rvm_detekt
mergify[bot] Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions buildSrc/src/main/java/Config.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import org.gradle.api.Project
import java.text.SimpleDateFormat
import java.util.Date
import java.util.Locale

/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

object Config {
// Synchronized build configuration for all modules
const val compileSdkVersion = 33
Expand Down
2 changes: 1 addition & 1 deletion buildSrc/src/main/java/Dependencies.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ object Versions {
const val androidx_orchestrator = "1.4.2"
const val androidx_runner = "1.5.2"
const val androidx_uiautomator = "2.2.0"
const val detekt = "1.23.0"
const val detekt = "1.23.1"
const val jacoco = "0.8.10"
const val ktlint = "0.50.0"
const val mockwebserver = "4.11.0"
Expand Down
4 changes: 1 addition & 3 deletions config/detekt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ output-reports:
comments:
active: true
AbsentOrWrongFileLicense:
active: false
active: true # Enabled in https://bugzilla.mozilla.org/show_bug.cgi?id=1795140
licenseTemplateFile: 'license.template'
licenseTemplateIsRegex: false
CommentOverPrivateFunction:
Expand Down Expand Up @@ -666,8 +666,6 @@ style:
active: true
OptionalUnit:
active: false
OptionalWhenBraces:
active: false
PreferToOverPairSyntax:
active: false
ProtectedMemberInFinalClass:
Expand Down
3 changes: 3 additions & 0 deletions config/license.template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */