Treat Kotlin compiler warnings as errors.

app/build.gradle

@@ -90,6 +90,7 @@ android {
 
 tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).all {
     kotlinOptions {
+        allWarningsAsErrors = true
         freeCompilerArgs += "-opt-in=kotlinx.coroutines.ExperimentalCoroutinesApi"
         freeCompilerArgs += "-Xjvm-default=all"
         jvmTarget = "17"

app/src/main/java/org/mozilla/reference/browser/BrowserActivity.kt

@@ -85,7 +85,7 @@ open class BrowserActivity : AppCompatActivity() {
             }
         }
 
-        super.onBackPressed()
+        super.onBackPressedDispatcher.onBackPressed()
 
         removeSessionIfNeeded()
     }

app/src/main/java/org/mozilla/reference/browser/addons/AddonDetailsActivity.kt

@@ -16,6 +16,7 @@ import androidx.core.text.HtmlCompat
 import mozilla.components.feature.addons.Addon
 import mozilla.components.feature.addons.ui.translateDescription
 import mozilla.components.feature.addons.ui.translateName
+import mozilla.components.support.utils.ext.getParcelableExtraCompat
 import org.mozilla.reference.browser.R
 import java.text.DateFormat
 import java.text.SimpleDateFormat
@@ -28,7 +29,9 @@ class AddonDetailsActivity : AppCompatActivity() {
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         setContentView(R.layout.activity_add_on_details)
-        val addon = requireNotNull(intent.getParcelableExtra<Addon>("add_on"))
+        val addon = requireNotNull(
+            intent.getParcelableExtraCompat("add_on", Addon::class.java),
+        )
         bind(addon)
     }
 

app/src/main/java/org/mozilla/reference/browser/addons/AddonSettingsActivity.kt

@@ -16,6 +16,8 @@ import mozilla.components.concept.engine.EngineSession
 import mozilla.components.concept.engine.EngineView
 import mozilla.components.feature.addons.Addon
 import mozilla.components.feature.addons.ui.translateName
+import mozilla.components.support.utils.ext.getParcelableCompat
+import mozilla.components.support.utils.ext.getParcelableExtraCompat
 import org.mozilla.reference.browser.R
 import org.mozilla.reference.browser.ext.components
 
@@ -28,7 +30,10 @@ class AddonSettingsActivity : AppCompatActivity() {
         super.onCreate(savedInstanceState)
         setContentView(R.layout.activity_add_on_settings)
 
-        val addon = requireNotNull(intent.getParcelableExtra<Addon>("add_on"))
+        val addon = requireNotNull(
+            intent.getParcelableExtraCompat("add_on", Addon::class.java),
+        )
+
         title = addon.translateName(this)
 
         supportFragmentManager
@@ -51,7 +56,13 @@ class AddonSettingsActivity : AppCompatActivity() {
         private lateinit var engineSession: EngineSession
 
         override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
-            optionsPageUrl = requireNotNull(arguments?.getParcelable<Addon>("add_on")?.installedState?.optionsPageUrl)
+            optionsPageUrl = requireNotNull(
+                arguments?.getParcelableCompat(
+                    "add_on",
+                    Addon::class.java,
+                )?.installedState?.optionsPageUrl,
+            )
+
             engineSession = requireContext().components.core.engine.createSession()
 
             return inflater.inflate(R.layout.fragment_add_on_settings, container, false)

app/src/main/java/org/mozilla/reference/browser/addons/InstalledAddonDetailsActivity.kt

@@ -18,6 +18,7 @@ import kotlinx.coroutines.launch
 import mozilla.components.feature.addons.Addon
 import mozilla.components.feature.addons.AddonManagerException
 import mozilla.components.feature.addons.ui.translateName
+import mozilla.components.support.utils.ext.getParcelableExtraCompat
 import org.mozilla.reference.browser.R
 import org.mozilla.reference.browser.ext.components
 
@@ -31,9 +32,12 @@ class InstalledAddonDetailsActivity : AppCompatActivity() {
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         setContentView(R.layout.activity_installed_add_on_details)
-        val addon = requireNotNull(intent.getParcelableExtra<Addon>("add_on")).also {
+        val addon = requireNotNull(
+            intent.getParcelableExtraCompat("add_on", Addon::class.java),
+        ).also {
             bindUI(it)
         }
+
         bindAddon(addon)
     }
 

app/src/main/java/org/mozilla/reference/browser/addons/PermissionsDetailsActivity.kt

@@ -16,6 +16,7 @@ import androidx.recyclerview.widget.LinearLayoutManager
 import androidx.recyclerview.widget.RecyclerView
 import mozilla.components.feature.addons.Addon
 import mozilla.components.feature.addons.ui.translateName
+import mozilla.components.support.utils.ext.getParcelableExtraCompat
 import org.mozilla.reference.browser.R
 
 private const val LEARN_MORE_URL =
@@ -28,7 +29,10 @@ class PermissionsDetailsActivity : AppCompatActivity(), View.OnClickListener {
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         setContentView(R.layout.activity_add_on_permissions)
-        val addon = requireNotNull(intent.getParcelableExtra<Addon>("add_on"))
+        val addon = requireNotNull(
+            intent.getParcelableExtraCompat("add_on", Addon::class.java),
+        )
+
         title = addon.translateName(this)
 
         bindPermissions(addon)

app/src/main/java/org/mozilla/reference/browser/addons/WebExtensionActionPopupActivity.kt

@@ -98,7 +98,7 @@ class WebExtensionActionPopupActivity : AppCompatActivity() {
 
         override fun onWindowRequest(windowRequest: WindowRequest) {
             if (windowRequest.type == WindowRequest.Type.CLOSE) {
-                activity?.onBackPressed()
+                activity?.onBackPressedDispatcher?.onBackPressed()
             }
         }
 

app/src/main/java/org/mozilla/reference/browser/browser/CrashIntegration.kt

@@ -8,22 +8,23 @@ import android.content.BroadcastReceiver
 import android.content.Context
 import android.content.Intent
 import android.content.IntentFilter
-import androidx.lifecycle.Lifecycle
-import androidx.lifecycle.LifecycleObserver
-import androidx.lifecycle.OnLifecycleEvent
+import androidx.core.content.ContextCompat
+import androidx.lifecycle.DefaultLifecycleObserver
+import androidx.lifecycle.LifecycleOwner
 import kotlinx.coroutines.DelicateCoroutinesApi
 import kotlinx.coroutines.GlobalScope
 import kotlinx.coroutines.launch
 import mozilla.components.lib.crash.Crash
 import mozilla.components.lib.crash.CrashReporter
+import mozilla.components.support.utils.ext.registerReceiverCompat
 import org.mozilla.reference.browser.BrowserApplication.Companion.NON_FATAL_CRASH_BROADCAST
 import org.mozilla.reference.browser.ext.isCrashReportActive
 
 class CrashIntegration(
     private val context: Context,
     private val crashReporter: CrashReporter,
     private val onCrash: (Crash) -> Unit,
-) : LifecycleObserver {
+) : DefaultLifecycleObserver {
 
     private val receiver = object : BroadcastReceiver() {
         override fun onReceive(context: Context, intent: Intent) {
@@ -36,15 +37,19 @@ class CrashIntegration(
         }
     }
 
-    @OnLifecycleEvent(Lifecycle.Event.ON_START)
-    fun start() {
+    override fun onStart(owner: LifecycleOwner) {
+        super.onStart(owner)
         if (isCrashReportActive) {
-            context.registerReceiver(receiver, IntentFilter(NON_FATAL_CRASH_BROADCAST))
+            context.registerReceiverCompat(
+                receiver,
+                IntentFilter(NON_FATAL_CRASH_BROADCAST),
+                ContextCompat.RECEIVER_NOT_EXPORTED,
+            )
         }
     }
 
-    @OnLifecycleEvent(Lifecycle.Event.ON_STOP)
-    fun stop() {
+    override fun onStop(owner: LifecycleOwner) {
+        super.onStop(owner)
         if (isCrashReportActive) {
             context.unregisterReceiver(receiver)
         }

app/src/main/java/org/mozilla/reference/browser/browser/ExternalAppBrowserFragment.kt

@@ -20,6 +20,7 @@ import mozilla.components.feature.pwa.feature.WebAppSiteControlsFeature
 import mozilla.components.support.base.feature.UserInteractionHandler
 import mozilla.components.support.base.feature.ViewBoundFeatureWrapper
 import mozilla.components.support.ktx.android.arch.lifecycle.addObservers
+import mozilla.components.support.utils.ext.getParcelableArrayListCompat
 import org.mozilla.reference.browser.R
 import org.mozilla.reference.browser.ext.requireComponents
 
@@ -41,7 +42,7 @@ class ExternalAppBrowserFragment : BaseBrowserFragment(), UserInteractionHandler
     private val manifest: WebAppManifest?
         get() = arguments?.getWebAppManifest()
     private val trustedScopes: List<Uri>
-        get() = arguments?.getParcelableArrayList<Uri>(ARG_TRUSTED_SCOPES).orEmpty()
+        get() = arguments?.getParcelableArrayListCompat(ARG_TRUSTED_SCOPES, Uri::class.java).orEmpty()
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)

app/src/main/java/org/mozilla/reference/browser/settings/AccountSettingsFragment.kt

@@ -127,7 +127,7 @@ class AccountSettingsFragment : PreferenceFragmentCompat() {
         return OnPreferenceClickListener {
             CoroutineScope(Dispatchers.Main).launch {
                 requireComponents.backgroundServices.accountManager.logout()
-                activity?.onBackPressed()
+                activity?.onBackPressedDispatcher?.onBackPressed()
             }
             true
         }

app/src/main/java/org/mozilla/reference/browser/settings/CustomColorPreference.kt

@@ -44,9 +44,9 @@ class CustomColorPreference @JvmOverloads constructor(
 
     override fun onBindViewHolder(holder: PreferenceViewHolder) {
         super.onBindViewHolder(holder)
-        holder?.let {
-            val title = it.itemView.findViewById(android.R.id.title) as TextView
-            val summary = it.itemView.findViewById(android.R.id.summary) as TextView
+        holder.apply {
+            val title = this.itemView.findViewById(android.R.id.title) as TextView
+            val summary = this.itemView.findViewById(android.R.id.summary) as TextView
             title.setTextColor(titleColor)
             summary.setTextColor(summaryColor)
         }

app/src/main/java/org/mozilla/reference/browser/settings/SettingsActivity.kt

@@ -25,7 +25,7 @@ class SettingsActivity : AppCompatActivity(), SettingsFragment.ActionBarUpdater
 
     override fun onOptionsItemSelected(item: MenuItem): Boolean = when (item.itemId) {
         android.R.id.home -> {
-            onBackPressed()
+            onBackPressedDispatcher.onBackPressed()
             true
         }
         else -> super.onOptionsItemSelected(item)
@@ -40,7 +40,7 @@ class SettingsActivity : AppCompatActivity(), SettingsFragment.ActionBarUpdater
             if (it is UserInteractionHandler && it.onBackPressed()) {
                 return
             } else {
-                super.onBackPressed()
+                super.onBackPressedDispatcher.onBackPressed()
             }
         }
     }

app/src/main/java/org/mozilla/reference/browser/settings/SettingsFragment.kt

@@ -8,6 +8,7 @@ import android.content.DialogInterface
 import android.content.Intent
 import android.os.Bundle
 import android.os.Handler
+import android.os.Looper
 import android.provider.Settings
 import android.view.View
 import android.widget.EditText
@@ -219,7 +220,7 @@ class SettingsFragment : PreferenceFragmentCompat() {
                         Toast.LENGTH_LONG,
                     ).show()
 
-                    Handler().postDelayed(
+                    Handler(Looper.getMainLooper()).postDelayed(
                         {
                             exitProcess(0)
                         },