Disable Generic Worker interactive and D2G features by default #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only the default, they can be enabled for specific worker pools.
bhearsum
reviewed
Nov 22, 2024
| @@ -60,6 +60,8 @@ worker-defaults: | |||
| disableReboots: false | |||
| downloadsDir: Z:\downloads | |||
| ed25519SigningKeyLocation: C:\generic-worker\ed25519-private.key | |||
| enableD2G: false | |||
There was a problem hiding this comment.
I don't think this is doing what you think it is. This is the default config for generic-worker/windows. At the very least you'll want this in the other sections here, and perhaps to remove enableD2G from this one?
ahal
requested changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable features unless explicitly enabled:
Worker pools have can opt in to these features, but without explicitly enabling, they will be disabled.