Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #220, allows any track to be "rolled out" to #221

Merged
merged 3 commits into from
Aug 28, 2019
Merged

Fixes #220, allows any track to be "rolled out" to #221

merged 3 commits into from
Aug 28, 2019

Conversation

mitchhentges
Copy link
Contributor

I'm going to test this by rerunning this task before we land this.

Ready for CR, though :)

@coveralls
Copy link

coveralls commented Aug 14, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 94.713% when pulling 042ef7d on mitchhentges:220-partial-rollout-v3 into 4a35ddf on mozilla-releng:master.

@mitchhentges mitchhentges force-pushed the 220-partial-rollout-v3 branch from d3bf3fc to 8f7cdff Compare August 14, 2019 18:44
escapewindow
escapewindow approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@escapewindow escapewindow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in channel, I think this is a breaking change since it looks like rollout will raise. i’d lean towards a major version bump. Otherwise, if the test task passes, lgtm.

@mitchhentges mitchhentges force-pushed the 220-partial-rollout-v3 branch from 8f7cdff to 7009cbb Compare August 14, 2019 19:29
@mitchhentges mitchhentges force-pushed the 220-partial-rollout-v3 branch from 7009cbb to b224313 Compare August 14, 2019 19:32
MihaiTabara
MihaiTabara approved these changes Aug 15, 2019
View reviewed changes
Copy link

@MihaiTabara MihaiTabara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for major number version bump.

@mitchhentges mitchhentges force-pushed the 220-partial-rollout-v3 branch from b224313 to 042ef7d Compare August 28, 2019 23:03
@mitchhentges mitchhentges marked this pull request as ready for review August 28, 2019 23:03
@mitchhentges
Copy link
Contributor Author

I've resolved the issue with rollout not working - in fact, none of the changes were being committed. Unfortunately, since we didn't want to affect too many reference-browser users when testing, we were only using rollout. Additionally, this coupled with the original rollout-fixing code for #220 being tested at the same time as the large transaction refactor (#213), meant that "commits not being applied" bug from #213 was incorrectly conflated.

Anyways, this commit resolves the issue.

@mitchhentges mitchhentges merged commit f696d5b into mozilla-releng:master Aug 28, 2019
@mitchhentges mitchhentges deleted the 220-partial-rollout-v3 branch August 28, 2019 23:14
@mitchhentges mitchhentges mentioned this pull request Aug 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MihaiTabara MihaiTabara MihaiTabara approved these changes

@escapewindow escapewindow escapewindow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mitchhentges @coveralls @MihaiTabara @escapewindow