Skip to content

Commit

Permalink
remove statsd client set up from signer/xpi.TestSignFile
Browse files Browse the repository at this point in the history
Not a huge contributor to TestSignFile's resource usage, but good to
remove like we've removed from the other tests. If we need to test that
behavior, we can use the mock.
  • Loading branch information
jmhodges committed Nov 5, 2024
1 parent 9a8a85e commit 1b7f075
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions signer/xpi/xpi_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,7 @@ func TestSignFile(t *testing.T) {
t.Run(fmt.Sprintf("test sign file %s signer id %s (%d)", input.name, testcase.ID, i), func(t *testing.T) {
t.Parallel()

statsdClient, err := statsd.NewBuffered("localhost:8135", 1)
if err != nil {
t.Fatalf("passing testcase %d: Error constructing statsdClient: %v", i, err)
}
statsdClient.Namespace = "test_autograph_stats_ns"
signerStatsClient, err := signer.NewStatsClient(testcase, statsdClient)
signerStatsClient, err := signer.NewStatsClient(testcase, &statsd.NoOpClient{})
if err != nil {
t.Fatalf("passing testcase %d: Error constructing signer.StatsdClient: %v", i, err)
}
Expand Down

0 comments on commit 1b7f075

Please sign in to comment.