move stats setting to newAutographer

mozilla-services · Jul 30, 2024 · b2f580a · b2f580a
1 parent c91a7d3
commit b2f580a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/main.go b/main.go
@@ -291,6 +291,7 @@ func newAutographer(cachesize int) (a *autographer) {
 	a.authBackend = newInMemoryAuthBackend()
 	a.nonces, err = lru.New(cachesize)
 	a.exit = make(chan interface{})
+	a.stats = &statsd.NoOpClient{}
 	if err != nil {
 		log.Fatal(err)
 	}

diff --git a/stats.go b/stats.go
@@ -20,7 +20,8 @@ func loadStatsd(conf configuration) (*statsd.Client, error) {
 
 func (a *autographer) addStats(conf configuration) (err error) {
 	if conf.Statsd.Addr != "" {
-		a.stats = &statsd.NoOpClient{}
+		// a.stats is set to a safe value in newAutographer, so we leave it
+		// alone and return.
 		log.Infof("Statsd disabled as no statsd address was provided")
 		return nil
 	}