Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compose override example #800

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add compose override example #800

wants to merge 2 commits into from

Conversation

g-k
Copy link
Contributor

@g-k g-k commented Nov 19, 2021

Changes:

  • add an example docker compose override file for local dev
  • add a unit-test make target (the image is only used for CI, but it's included since we have make integration-test)
  • readme: remove local install directions
    • go get is deprecated
    • local dev requirements are outdated and unsupported due to signers shelling out and writing stuff to temp now
  • readme: add docker-compose install / local dev directions

@g-k g-k force-pushed the add-compose-override-example branch from fc7b267 to d1e68be Compare November 19, 2021 16:14
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7633

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.27%
Totals Coverage Status
Change from base Build 7628: 0.0%
Covered Lines: 3401
Relevant Lines: 4772
💛 - Coveralls

@g-k g-k marked this pull request as ready for review November 19, 2021 16:33
@g-k g-k requested review from kkleemola and pwnbus November 19, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkleemola kkleemola Awaiting requested review from kkleemola

@pwnbus pwnbus Awaiting requested review from pwnbus

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-k @coveralls