remove nil checks around uses of autographer.stats #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmhodges
force-pushed
the
statsd-null-object-remove-checks
branch
2 times, most recently
from
318268a
to
56f1628
Compare
jmhodges
changed the title
bhearsum
previously approved these changes
Jul 31, 2024
jmhodges
force-pushed
the
statsd-null-object
branch
from
934e070
to
4260381
Compare
This removes the now unneeded checks to see if `autographer.stats` is nil wherever we gather stats. We also remove some nil checks in signer.StatsClient that are no longer workable as it accepts the statds.ClientInterface type. Some of the older code was checking for error returns that they probably shouldn't (logging about metrics problems tends to clutter up code and the alerting should already tell you you have a problem), but we leave those alone for now. Updates AUT-159
jmhodges
force-pushed
the
statsd-null-object-remove-checks
branch
from
56f1628
to
3bffa70
Compare
|
Ugh, when you change the base branch, it dismisses reviews. Sorry. |
bhearsum
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the now unneeded checks to see if
autographer.statsisnil wherever we gather stats.
We also remove some nil checks in signer.StatsClient that are no longer
workable as it accepts the statds.ClientInterface type.
Some of the older code was checking for error returns that they probably
shouldn't (logging about metrics problems tends to clutter up code and
the alerting should already tell you you have a problem), but we leave
those alone for now.
Updates AUT-159