bump go.mod go version to 1.22.1 #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to speed up our build and CI. Our current debian dpkg package install for Go installs Go 1.21.1. When that version sees a Go 1.22.x version greater than itself, it downloads and installs that newer version. This takes a lot of time and happens across many of our CI jobs and docker image builds. This downgrade will have no impact on our security posture (its just for dep version selection) and our dependencies won't be setting their minimum go version this high for a while. It might be better for us to just install on a docker image that has the right Go version installed and allows us to keep up to date in those other dpkgs without doing `apt-get update`s (by having a cache of the package info regularly updated and published as new docker image tags and our dependabot can detect those).
jmhodges
requested review from
oskirby and
bhearsum
and removed request for
a team
bhearsum
approved these changes
Jul 31, 2024
jmhodges
added a commit
to mozilla-services/autograph-edge
that referenced
this pull request
Aug 27, 2024
This is for mozilla-services/autograph#937 and also fixes the cgo dependency in this dockerfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to speed up our build and CI.
Our current debian dpkg package install for Go installs Go 1.21.1. When
that version sees a Go 1.22.x version greater than itself, it downloads
and installs that newer version. This takes a lot of time and happens
across many of our CI jobs and docker image builds.
This downgrade will have no impact on our security posture
(its just for dep version selection) and our dependencies won't be
setting their minimum go version this high for a while.
It might be better for us to just install on a docker image that has the
right Go version installed and allows us to keep up to date in those
other dpkgs without doing
apt-get updates (by having a cache of thepackage info regularly updated and published as new docker image tags
and our dependabot can detect those).