Fetch autograph logs in Github actions integration tests #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhearsum
reviewed
Aug 1, 2024
|
|
||
| - name: Fetching autograph logs | ||
| shell: bash | ||
| if: ${{ always() }} |
There was a problem hiding this comment.
Will this cause issues if we don't reach the previous step? Maybe we don't care if this fails in weird ways if something early (eg: checking out) fails?
There was a problem hiding this comment.
If the container never starts, this just outputs nothing so the failure mode is a no-op in this case.
I also don't think it matters if the job fails in weird ways at this point as we are already dealing with an error. What's one more?
bhearsum
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should add a step after an integration test runs that outputs the logs from the autograph container to the github workflow console. This should better allow us to investigate the cause of a failure. Note that the use of
if: ${{ always() }}should cause this step to be run even if the preceeding steps result in a failure.