Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow missing trailing slashes in chainUploadLocation #970

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

allow missing trailing slashes in chainUploadLocation #970

wants to merge 7 commits into from

Commits on Sep 4, 2024

  1. trim leading slash before uploading chains to S3 

    The stage environment went down for a while. The details of why can be
found in AUT-231.

One of the triggers was that aws-go-sdk-v2 no longer removes leading
slashes from uploaded S3 key names like the v1 version of the library
did. That caused some cascading failures leading to too many AWS
CloudHSM slots being consumed.

This change trims the leading slashes from the uploaded S3 key names for
the contentsignaturepki certificate chains.

This change also gets us closer to not needing to be careful about
remembering to end chainUploadLocation strings with a slash with an
application of `path.Join`. The `file://` handling elsewhere is still
bugged.

Updates AUT-233
Updates AUT-231
    @jmhodges
    jmhodges committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    ea5f0b5 View commit details
    Browse the repository at this point in the history

  2. started as just filepath.Join(target.Path, name) in writeLocalFile 

    Then noticed we were modifying http.Client live in the process
    @jmhodges
    jmhodges committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    50f6fb9 View commit details
    Browse the repository at this point in the history

  3. make subtests for easier testing

    @jmhodges
    jmhodges committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    e0bd868 View commit details
    Browse the repository at this point in the history

  4. join the X5U

    @jmhodges
    jmhodges committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    a3bce66 View commit details
    Browse the repository at this point in the history

  5. remove FIXME log

    @jmhodges
    jmhodges committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0fdb335 View commit details
    Browse the repository at this point in the history

  6. use url.JoinPath to correctly escape and join x5u and chainName

    @jmhodges
    jmhodges committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b91d6ce View commit details
    Browse the repository at this point in the history

  7. use default http client everywhere now since we're not modifying it

    @jmhodges
    jmhodges committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5ab08d2 View commit details
    Browse the repository at this point in the history