Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bundle sqlite [ci full] #6433

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: bundle sqlite [ci full] #6433

merged 1 commit into from
Oct 25, 2024

Conversation

gruberb
Copy link
Member

@gruberb gruberb commented Oct 25, 2024

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.76%. Comparing base (acf12a1) to head (115808a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6433   +/-   ##
=======================================
  Coverage   21.76%   21.76%           
=======================================
  Files         344      344           
  Lines       31100    31100           
=======================================
  Hits         6768     6768           
  Misses      24332    24332           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bendk bendk changed the title fix: bundle sqlite fix: bundle sqlite [ci full] Oct 25, 2024
Copy link
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me, but can you force-push again to trigger the [ci full] tasks?

Copy link
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the CI tests pass, I think this is ready to go.

@gruberb gruberb added this pull request to the merge queue Oct 25, 2024
@bendk bendk removed this pull request from the merge queue due to a manual request Oct 25, 2024
@bendk
Copy link
Contributor

bendk commented Oct 25, 2024

Wait, did the full CI tasks run? You need to push again after the title is updated for that to happen. I usually just do git commit --amend to get a new commit ID then force push it.

@bendk
Copy link
Contributor

bendk commented Oct 25, 2024

When [full ci] takes affect, you'll see a couple dozen tasks under the firefoxci-taskcluster heading.

@gruberb gruberb added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit f7f0add Oct 25, 2024
58 checks passed
@gruberb gruberb deleted the fix-sqlite branch October 25, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants