Use optional chaining to avoid undefined monthly_monitor_report (#5511)

mozilla · Jan 22, 2025 · 846bc04 · 846bc04
1 parent 287d445
commit 846bc04
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/.../(proper_react)/(redesign)/(authenticated)/user/(dashboard)/settings/AlertAddressForm.tsx b/.../(proper_react)/(redesign)/(authenticated)/user/(dashboard)/settings/AlertAddressForm.tsx
@@ -38,7 +38,7 @@ import { useTelemetry } from "../../../../../../hooks/useTelemetry";
 export type Props = {
   user: Session["user"];
   subscriber: SubscriberRow;
-  data: SubscriberEmailPreferencesOutput;
+  data?: SubscriberEmailPreferencesOutput;
   enabledFeatureFlags: FeatureFlagName[];
 };
 
@@ -53,8 +53,8 @@ export const AlertAddressForm = (props: Props) => {
 
   // Extract monthly report preference from the right column
   const monitorReportAllowed = hasPremium(props.user)
-    ? props.data.monthly_monitor_report
-    : props.data.monthly_monitor_report_free;
+    ? props.data?.monthly_monitor_report
+    : props.data?.monthly_monitor_report_free;
 
   // TODO: Deprecate this when monthly report for free users has been created
   const canToggleFreeOrPlusMonthlyReport =

diff --git a/...redesign)/(authenticated)/user/(dashboard)/settings/panels/SettingsPanelNotifications.tsx b/...redesign)/(authenticated)/user/(dashboard)/settings/panels/SettingsPanelNotifications.tsx
@@ -30,7 +30,7 @@ export type SettingsPanelNotificationsProps = {
 export type NotificationSettingsProps = {
   user: Session["user"];
   subscriber: SubscriberRow;
-  data: SubscriberEmailPreferencesOutput;
+  data?: SubscriberEmailPreferencesOutput;
 };
 
 const EmailCommOption = {
@@ -53,8 +53,8 @@ export const NotificationsSettings = (props: NotificationSettingsProps) => {
 
   // Extract monthly report preference from the right column
   const monitorReportAllowed = hasPremium(props.user)
-    ? props.data.monthly_monitor_report
-    : props.data.monthly_monitor_report_free;
+    ? props.data?.monthly_monitor_report
+    : props.data?.monthly_monitor_report_free;
 
   const defaultActivateAlertEmail =
     typeof breachAlertsEmailsAllowed === "boolean";