Unify setting the preview mode for getExperiments #5575
+21
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL 🚀 : https://blurts-server-pr-5575-mgjlpikfea-uk.a.run.app |
flozia
requested review from
rhelmer and
Vinnl
and removed request for
rhelmer
Vinnl
approved these changes
Feb 3, 2025
Comment on lines
+56
to
+57
| // Check for Nimbus preview mode. Note that this requires a full page reload | ||
| // to activate: https://nextjs.org/docs/app/api-reference/file-conventions/layout#caveats |
There was a problem hiding this comment.
This comment doesn't quite seem to apply here, though it could possibly reworded to talk about if getExperiments is called in a layout.
(That said, I'm not sure what the failure mode here is - surely the query parameter only gets added by manually adjusting the URL, in which case pressing Enter seems implied? We're not supposed to add <Link>s with these query params, right?)
rhelmer
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-4011
Description
At the moment, we have two ways of forcing experiments via
nimbus_preview:nimbus_previewin pagesx-nimbus-preview-modein layouts (which is getting set by the search paramnimbus_previewin the middleware)This PR unifies the the Nimbus preview to check
x-nimbus-preview-modeonly and moves the condition intogetExperiments.How to test
Append
/?nimbus_previewto a URL that has disabled experiments.Checklist (Definition of Done)