Remove non ASCII from texture diagrams (gpuweb#4008)

Even in 2024 Google/Chromium's infra can't handle unicode 🤬
mozilla · Oct 25, 2024 · 3b58c42 · 3b58c42
1 parent 916e404
commit 3b58c42
Showing 1 changed file with 35 additions and 35 deletions.
diff --git a/src/webgpu/shader/execution/expression/call/builtin/texture_utils.ts b/src/webgpu/shader/execution/expression/call/builtin/texture_utils.ts
@@ -2857,23 +2857,23 @@ const kFaceNames = ['+x', '-x', '+y', '-y', '+z', '-z'] as const;
  * Example:
  *
  *     0   1   2   3   4   5   6   7
- *   ┌───┬───┬───┬───┬───┬───┬───┬───┐
- * 0 │   │   │   │   │   │   │   │   │
- *   ├───┼───┼───┼───┼───┼───┼───┼───┤
- * 1 │   │   │   │   │   │   │   │ a │
- *   ├───┼───┼───┼───┼───┼───┼───┼───┤
- * 2 │   │   │   │   │   │   │   │ b │
- *   ├───┼───┼───┼───┼───┼───┼───┼───┤
- * 3 │   │   │   │   │   │   │   │   │
- *   ├───┼───┼───┼───┼───┼───┼───┼───┤
- * 4 │   │   │   │   │   │   │   │   │
- *   ├───┼───┼───┼───┼───┼───┼───┼───┤
- * 5 │   │   │   │   │   │   │   │   │
- *   ├───┼───┼───┼───┼───┼───┼───┼───┤
- * 6 │   │   │   │   │   │   │   │   │
- *   ├───┼───┼───┼───┼───┼───┼───┼───┤
- * 7 │   │   │   │   │   │   │   │   │
- *   └───┴───┴───┴───┴───┴───┴───┴───┘
+ *   +---+---+---+---+---+---+---+---+
+ * 0 |   |   |   |   |   |   |   |   |
+ *   +---+---+---+---+---+---+---+---+
+ * 1 |   |   |   |   |   |   |   | a |
+ *   +---+---+---+---+---+---+---+---+
+ * 2 |   |   |   |   |   |   |   | b |
+ *   +---+---+---+---+---+---+---+---+
+ * 3 |   |   |   |   |   |   |   |   |
+ *   +---+---+---+---+---+---+---+---+
+ * 4 |   |   |   |   |   |   |   |   |
+ *   +---+---+---+---+---+---+---+---+
+ * 5 |   |   |   |   |   |   |   |   |
+ *   +---+---+---+---+---+---+---+---+
+ * 6 |   |   |   |   |   |   |   |   |
+ *   +---+---+---+---+---+---+---+---+
+ * 7 |   |   |   |   |   |   |   |   |
+ *   +---+---+---+---+---+---+---+---+
  * a: at: [7, 1], weights: [R: 0.75000]
  * b: at: [7, 2], weights: [R: 0.25000]
  */
@@ -3016,15 +3016,15 @@ async function identifySamplePoints<T extends Dimensionality>(
     layerEntries.set(xyId, weight);
   }
 
-  // ┌───┬───┬───┬───┐
-  // │ a │   │   │   │
-  // ├───┼───┼───┼───┤
-  // │   │   │   │   │
-  // ├───┼───┼───┼───┤
-  // │   │   │   │   │
-  // ├───┼───┼───┼───┤
-  // │   │   │   │ b │
-  // └───┴───┴───┴───┘
+  // +---+---+---+---+
+  // | a |   |   |   |
+  // +---+---+---+---+
+  // |   |   |   |   |
+  // +---+---+---+---+
+  // |   |   |   |   |
+  // +---+---+---+---+
+  // |   |   |   | b |
+  // +---+---+---+---+
   const lines: string[] = [];
   const letter = (idx: number) => String.fromCodePoint(idx < 30 ? 97 + idx : idx + 9600 - 30); // 97: 'a'
   let idCount = 0;
@@ -3063,39 +3063,39 @@ async function identifySamplePoints<T extends Dimensionality>(
         lines.push(line);
       }
       {
-        let line = '  ┌';
+        let line = '  +';
         for (let x = 0; x < width; x++) {
-          line += x === width - 1 ? '───┐' : '───┬';
+          line += x === width - 1 ? '---+' : '---+';
         }
         lines.push(line);
       }
       for (let y = 0; y < height; y++) {
         {
-          let line = `${y.toString().padEnd(2)}│`;
+          let line = `${y.toString().padEnd(2)}|`;
           for (let x = 0; x < width; x++) {
             const texelIdx = x + y * texelsPerRow;
             const weight = layerEntries.get(texelIdx);
             if (weight !== undefined) {
-              line += ` ${letter(idCount + orderedTexelIndices.length)} │`;
+              line += ` ${letter(idCount + orderedTexelIndices.length)} |`;
               orderedTexelIndices.push(texelIdx);
             } else {
-              line += '   │';
+              line += '   |';
             }
           }
           lines.push(line);
         }
         if (y < height - 1) {
-          let line = '  ├';
+          let line = '  +';
           for (let x = 0; x < width; x++) {
-            line += x === width - 1 ? '───┤' : '───┼';
+            line += x === width - 1 ? '---+' : '---+';
           }
           lines.push(line);
         }
       }
       {
-        let line = '  └';
+        let line = '  +';
         for (let x = 0; x < width; x++) {
-          line += x === width - 1 ? '───┘' : '───┴';
+          line += x === width - 1 ? '---+' : '---+';
         }
         lines.push(line);
       }