Skip to content

Commit

Permalink
Merge pull request #2280 from larseggert/ci-coverage-mcdc
Browse files Browse the repository at this point in the history
* ci: Enable MC/DC coverage

en.wikipedia.org/wiki/Code_coverage#Modified_condition/decision_coverage

MC/DC is finding some partially covered lines, so coverage drops. This is expected.

* One more nightly
  • Loading branch information
martinthomson authored Dec 11, 2024
2 parents a1b9364 + cf3830d commit 0e6d3be
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ jobs:
- uses: ./.github/actions/rust
with:
version: ${{ matrix.rust-toolchain }}
components: ${{ matrix.rust-toolchain == 'stable' && 'llvm-tools-preview' || '' }}
tools: ${{ matrix.rust-toolchain == 'stable' && 'cargo-llvm-cov, ' || '' }} cargo-nextest
components: ${{ matrix.rust-toolchain == 'nightly' && 'llvm-tools' || '' }}
tools: ${{ matrix.rust-toolchain == 'nightly' && 'cargo-llvm-cov, ' || '' }} cargo-nextest
token: ${{ secrets.GITHUB_TOKEN }}

- id: nss-version
Expand All @@ -88,8 +88,8 @@ jobs:
DUMP_SIMULATION_SEEDS="$(pwd)/simulation-seeds"
export DUMP_SIMULATION_SEEDS
# shellcheck disable=SC2086
if [ "${{ matrix.rust-toolchain }}" == "stable" ]; then
cargo +${{ matrix.rust-toolchain }} llvm-cov nextest $BUILD_TYPE --features ci --profile ci --lcov --output-path lcov.info
if [ "${{ matrix.rust-toolchain }}" == "nightly" ]; then
cargo +${{ matrix.rust-toolchain }} llvm-cov nextest $BUILD_TYPE --mcdc --features ci --profile ci --lcov --output-path lcov.info
else
cargo +${{ matrix.rust-toolchain }} nextest run $BUILD_TYPE --features ci --profile ci
fi
Expand Down Expand Up @@ -119,7 +119,7 @@ jobs:
verbose: true
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
if: matrix.type == 'debug' && matrix.rust-toolchain == 'stable'
if: matrix.type == 'debug' && matrix.rust-toolchain == 'nightly'

- name: Save simulation seeds artifact
if: always()
Expand Down

0 comments on commit 0e6d3be

Please sign in to comment.