[StepSecurity] Add CodeQL Workflow (SAST Tool) #1946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: StepSecurity Bot <[email protected]>
step-security-bot
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
larseggert
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1946 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 110 110
Lines 35773 35773
=======================================
Hits 33918 33918
Misses 1855 1855 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to ea54273. coalesce_acked_from_zero 1+1 entries: 💔 Performance has regressed. time: [195.82 ns 196.24 ns 196.68 ns]
change: [+2.1602% +2.5511% +2.9349%] (p = 0.00 < 0.05)
Found 16 outliers among 100 measurements (16.00%)
1 (1.00%) low mild
9 (9.00%) high mild
6 (6.00%) high severecoalesce_acked_from_zero 3+1 entries: 💔 Performance has regressed. time: [237.94 ns 238.62 ns 239.31 ns]
change: [+2.0238% +2.5487% +3.2107%] (p = 0.00 < 0.05)
Found 20 outliers among 100 measurements (20.00%)
20 (20.00%) high severecoalesce_acked_from_zero 10+1 entries: 💔 Performance has regressed. time: [237.41 ns 238.15 ns 239.05 ns]
change: [+1.1573% +1.6667% +2.1180%] (p = 0.00 < 0.05)
Found 7 outliers among 100 measurements (7.00%)
2 (2.00%) low mild
5 (5.00%) high severecoalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [217.80 ns 218.01 ns 218.25 ns]
change: [+0.1729% +0.9810% +1.6981%] (p = 0.00 < 0.05)
Found 6 outliers among 100 measurements (6.00%)
3 (3.00%) high mild
3 (3.00%) high severeRxStreamOrderer::inbound_frame(): Change within noise threshold. time: [118.44 ms 118.54 ms 118.64 ms]
change: [+0.2819% +0.3975% +0.5189%] (p = 0.00 < 0.05)
Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high mildtransfer/Run multiple transfers with varying seeds: Change within noise threshold. time: [122.05 ms 122.30 ms 122.56 ms]
thrpt: [32.636 MiB/s 32.705 MiB/s 32.774 MiB/s]
change:
time: [+1.7322% +2.0333% +2.3445%] (p = 0.00 < 0.05)
thrpt: [-2.2908% -1.9928% -1.7027%]
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [1.0721 s 1.0921 s 1.1172 s]
thrpt: [89.509 MiB/s 91.569 MiB/s 93.271 MiB/s]
change:
time: [-2.7800% +0.3488% +3.4126%] (p = 0.84 > 0.05)
thrpt: [-3.3000% -0.3476% +2.8595%]
Found 2 outliers among 10 measurements (20.00%)
2 (20.00%) high severe1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [387.90 ms 391.18 ms 394.46 ms]
thrpt: [25.351 Kelem/s 25.564 Kelem/s 25.780 Kelem/s]
change:
time: [-1.5096% -0.3658% +0.7945%] (p = 0.52 > 0.05)
thrpt: [-0.7882% +0.3672% +1.5327%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
|
CodeQL doesn't do Rust yet, so limited benefit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is created by StepSecurity at the request of @larseggert. Please merge the Pull Request to incorporate the requested changes. Please tag @larseggert on your message if you have any questions related to the PR.
Security Fixes
Detect Vulnerabilities with SAST Workflow
Static Code Analysis (also known as Source Code Analysis) is usually performed as part of a Code Review (also known as clear-box testing) and is carried out at the Implementation phase of a Security Development Lifecycle (SDL). Static Code Analysis commonly refers to the running of Static Code Analysis tools that attempt to highlight possible vulnerabilities within ‘static’ (non-running) source code by using techniques such as Taint Analysis and Data Flow Analysis.
Feedback
For bug reports, feature requests, and general feedback; please email [email protected]. To create such PRs, please visit https://app.stepsecurity.io/securerepo.
Signed-off-by: StepSecurity Bot [email protected]