Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump actions/dependency-review-action from 4.3.4 to 4.3.5 #2205

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 28, 2024

Bumps actions/dependency-review-action from 4.3.4 to 4.3.5.

Release notes

Sourced from actions/dependency-review-action's releases.

v4.3.5

What's Changed

New Contributors

Full Changelog: actions/dependency-review-action@v4.3.4...v4.3.5

Commits
  • a6993e2 Merge pull request #840 from actions/dependabot-updates
  • d92f08b Bump eslint-plugin-jest and ts-jest
  • 3e334b7 Merge pull request #822 from actions/dependabot/npm_and_yarn/got-14.4.2
  • 32b7d88 Merge pull request #832 from actions/jonjanego-patch-3
  • 14b94f8 Update stale.yaml
  • 6ea3b24 Merge pull request #828 from actions/hm/summary
  • 05042db update dist packaging
  • 6aacbe0 add a warning message if there is room in the summary prior to cutoff
  • 293ccdb add truncation escape valve to new file summary to avoid overflow
  • 83c7cc6 Do not list changes dependencies in summary
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 28, 2024
@dependabot dependabot bot requested a review from larseggert as a code owner October 28, 2024 08:15
@dependabot dependabot bot added the github_actions Pull requests that update GitHub Actions code label Oct 28, 2024
@dependabot dependabot bot requested a review from mxinden as a code owner October 28, 2024 08:15
Copy link

github-actions bot commented Oct 28, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4.3.4 to 4.3.5.
- [Release notes](https://github.com/actions/dependency-review-action/releases)
- [Commits](actions/dependency-review-action@5a2ce3f...a6993e2)

---
updated-dependencies:
- dependency-name: actions/dependency-review-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/dependency-review-action-4.3.5 branch from e987585 to b1cb264 Compare October 28, 2024 09:13
@larseggert larseggert merged commit 8e36f63 into main Oct 28, 2024
27 of 33 checks passed
@larseggert larseggert deleted the dependabot/github_actions/actions/dependency-review-action-4.3.5 branch October 28, 2024 09:14
Copy link

Benchmark results

Performance differences relative to 8e36f63.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [99.205 ns 99.500 ns 99.803 ns]
       change: [-0.3020% +0.1157% +0.5435%] (p = 0.59 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
5 (5.00%) high mild
5 (5.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [117.04 ns 117.37 ns 117.73 ns]
       change: [-0.3815% +0.0616% +0.5895%] (p = 0.82 > 0.05)

Found 23 outliers among 100 measurements (23.00%)
1 (1.00%) low severe
2 (2.00%) low mild
8 (8.00%) high mild
12 (12.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [116.63 ns 117.00 ns 117.46 ns]
       change: [-0.9853% -0.2497% +0.5192%] (p = 0.53 > 0.05)

Found 17 outliers among 100 measurements (17.00%)
5 (5.00%) low severe
3 (3.00%) low mild
3 (3.00%) high mild
6 (6.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.303 ns 99.487 ns 104.48 ns]
       change: [-0.4341% +5.3359% +16.233%] (p = 0.37 > 0.05)

Found 8 outliers among 100 measurements (8.00%)
2 (2.00%) high mild
6 (6.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [111.83 ms 111.89 ms 111.95 ms]
       change: [+0.1222% +0.1953% +0.2688%] (p = 0.00 < 0.05)

Found 20 outliers among 100 measurements (20.00%)
9 (9.00%) low mild
4 (4.00%) high mild
7 (7.00%) high severe

transfer/pacing-false/varying-seeds: Change within noise threshold.
       time:   [26.165 ms 27.116 ms 28.079 ms]
       change: [-10.860% -6.1235% -1.0180%] (p = 0.02 < 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [36.401 ms 38.070 ms 39.759 ms]
       change: [-5.7484% +0.4056% +6.8379%] (p = 0.90 > 0.05)
transfer/pacing-false/same-seed: Change within noise threshold.
       time:   [26.089 ms 26.805 ms 27.515 ms]
       change: [-7.9770% -4.2535% +0.0146%] (p = 0.05 < 0.05)
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [41.520 ms 43.872 ms 46.270 ms]
       change: [-11.343% -4.5337% +2.5354%] (p = 0.22 > 0.05)
1-conn/1-100mb-resp/mtu-1500 (aka. Download)/client: 💔 Performance has regressed.
       time:   [948.73 ms 957.76 ms 966.74 ms]
       thrpt:  [103.44 MiB/s 104.41 MiB/s 105.40 MiB/s]
change:
       time:   [+5.1316% +6.5577% +8.0742%] (p = 0.00 < 0.05)
       thrpt:  [-7.4710% -6.1541% -4.8812%]
1-conn/10_000-parallel-1b-resp/mtu-1500 (aka. RPS)/client: No change in performance detected.
       time:   [318.15 ms 321.07 ms 324.12 ms]
       thrpt:  [30.853 Kelem/s 31.145 Kelem/s 31.432 Kelem/s]
change:
       time:   [-1.0567% +0.2895% +1.8086%] (p = 0.69 > 0.05)
       thrpt:  [-1.7765% -0.2886% +1.0680%]

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

1-conn/1-1b-resp/mtu-1500 (aka. HPS)/client: No change in performance detected.
       time:   [33.700 ms 33.928 ms 34.176 ms]
       thrpt:  [29.260  elem/s 29.474  elem/s 29.674  elem/s]
change:
       time:   [-1.4036% -0.4642% +0.5097%] (p = 0.35 > 0.05)
       thrpt:  [-0.5071% +0.4664% +1.4235%]

Found 8 outliers among 100 measurements (8.00%)
6 (6.00%) high mild
2 (2.00%) high severe

1-conn/1-100mb-resp/mtu-1500 (aka. Upload)/client: No change in performance detected.
       time:   [1.7716 s 1.7867 s 1.8019 s]
       thrpt:  [55.498 MiB/s 55.968 MiB/s 56.448 MiB/s]
change:
       time:   [-0.7626% +0.4847% +1.8318%] (p = 0.47 > 0.05)
       thrpt:  [-1.7989% -0.4823% +0.7684%]
1-conn/1-100mb-resp/mtu-65536 (aka. Download)/client: 💔 Performance has regressed.
       time:   [111.09 ms 111.35 ms 111.61 ms]
       thrpt:  [895.99 MiB/s 898.09 MiB/s 900.18 MiB/s]
change:
       time:   [+1.0540% +1.4029% +1.7478%] (p = 0.00 < 0.05)
       thrpt:  [-1.7178% -1.3835% -1.0430%]
1-conn/10_000-parallel-1b-resp/mtu-65536 (aka. RPS)/client: No change in performance detected.
       time:   [315.71 ms 319.17 ms 322.66 ms]
       thrpt:  [30.992 Kelem/s 31.331 Kelem/s 31.674 Kelem/s]
change:
       time:   [-0.8223% +0.7578% +2.4427%] (p = 0.34 > 0.05)
       thrpt:  [-2.3845% -0.7521% +0.8291%]

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

1-conn/1-1b-resp/mtu-65536 (aka. HPS)/client: Change within noise threshold.
       time:   [33.760 ms 33.959 ms 34.179 ms]
       thrpt:  [29.257  elem/s 29.447  elem/s 29.621  elem/s]
change:
       time:   [-1.8220% -0.9490% -0.0599%] (p = 0.03 < 0.05)
       thrpt:  [+0.0599% +0.9581% +1.8558%]

Found 6 outliers among 100 measurements (6.00%)
2 (2.00%) low mild
1 (1.00%) high mild
3 (3.00%) high severe

1-conn/1-100mb-resp/mtu-65536 (aka. Upload)/client: No change in performance detected.
       time:   [268.78 ms 292.80 ms 333.02 ms]
       thrpt:  [300.28 MiB/s 341.53 MiB/s 372.05 MiB/s]
change:
       time:   [-18.804% -5.6431% +11.350%] (p = 0.52 > 0.05)
       thrpt:  [-10.193% +5.9806% +23.158%]

Found 6 outliers among 100 measurements (6.00%)
4 (4.00%) high mild
2 (2.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing MTU Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 1504 108.0 ± 30.0 91.2 198.5 1.00
neqo msquic reno on 1504 211.8 ± 11.3 200.6 227.2 1.00
neqo msquic reno 1504 243.6 ± 75.7 204.1 477.5 1.00
neqo msquic cubic on 1504 218.0 ± 19.1 197.8 257.2 1.00
neqo msquic cubic 1504 251.8 ± 68.1 210.8 406.0 1.00
msquic neqo reno on 1504 704.4 ± 11.5 691.7 723.9 1.00
msquic neqo reno 1504 710.2 ± 6.2 701.3 718.8 1.00
msquic neqo cubic on 1504 715.2 ± 21.9 693.8 766.2 1.00
msquic neqo cubic 1504 704.1 ± 13.0 687.7 725.4 1.00
neqo neqo reno on 1504 442.5 ± 14.8 425.8 469.1 1.00
neqo neqo reno 1504 458.6 ± 57.2 412.0 583.2 1.00
neqo neqo cubic on 1504 426.7 ± 14.4 405.3 450.7 1.00
neqo neqo cubic 1504 426.1 ± 10.5 408.3 442.0 1.00
msquic msquic 65536 163.8 ± 75.9 91.2 328.0 1.00
neqo msquic reno on 65536 215.1 ± 11.5 197.7 232.0 1.00
neqo msquic reno 65536 234.2 ± 62.7 198.7 438.9 1.00
neqo msquic cubic on 65536 210.6 ± 11.0 198.4 230.6 1.00
neqo msquic cubic 65536 234.9 ± 61.6 203.0 437.0 1.00
msquic neqo reno on 65536 112.2 ± 62.2 83.2 333.0 1.00
msquic neqo reno 65536 133.5 ± 88.5 82.0 367.7 1.00
msquic neqo cubic on 65536 126.6 ± 97.9 80.2 588.9 1.00
msquic neqo cubic 65536 119.8 ± 72.5 82.3 372.8 1.00
neqo neqo reno on 65536 180.2 ± 102.2 124.1 567.4 1.00
neqo neqo reno 65536 155.9 ± 60.3 121.2 356.2 1.00
neqo neqo cubic on 65536 237.9 ± 159.0 135.6 662.2 1.00
neqo neqo cubic 65536 188.2 ± 68.1 126.8 386.3 1.00

⬇️ Download logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant