chore: Remove some unwraps and replace others by expect
#2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In functions that return `Result`.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 085fa62. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2294 +/- ##
==========================================
- Coverage 95.29% 95.24% -0.06%
==========================================
Files 114 114
Lines 36844 36877 +33
Branches 36844 36877 +33
==========================================
+ Hits 35111 35122 +11
- Misses 1727 1749 +22
Partials 6 6 ☔ View full report in Codecov by Sentry. |
larseggert
force-pushed
the
chore-unwrap-less
branch
from
cf9783c to
c9f1896
Compare
larseggert
changed the title
unwrapsunwraps and replace others by expect
| @@ -22,6 +22,7 @@ fn se_create() { | |||
| const PLAINTEXT: &[u8] = b"PLAINTEXT"; | |||
| const AAD: &[u8] = b"AAD"; | |||
|
|
|||
| #[cfg(test)] | |||
There was a problem hiding this comment.
?? This is in tests/. Why would it need this?
There was a problem hiding this comment.
I don't know, but it does. Otherwise clippy complains.
neqo-http3/src/features/extended_connect/webtransport_session.rs
Outdated
Show resolved
Hide resolved
neqo-http3/src/features/extended_connect/webtransport_session.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Thomson <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
Co-authored-by: Martin Thomson <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
Co-authored-by: Martin Thomson <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
Co-authored-by: Martin Thomson <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
Benchmark resultsPerformance differences relative to 6013bde. decode 4096 bytes, mask ff: No change in performance detected. time: [11.181 µs 11.230 µs 11.284 µs]
change: [-0.0792% +0.3436% +0.7985%] (p = 0.13 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0185 ms 3.0282 ms 3.0393 ms]
change: [-0.5043% -0.0128% +0.4833%] (p = 0.96 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.546 µs 19.602 µs 19.663 µs]
change: [-0.6599% +0.1716% +1.1972%] (p = 0.74 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.1564 ms 5.1675 ms 5.1792 ms]
change: [-0.5253% -0.1676% +0.1604%] (p = 0.34 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5377 µs 5.5741 µs 5.6188 µs]
change: [-0.8808% -0.1328% +0.5290%] (p = 0.73 > 0.05)
decode 1048576 bytes, mask 3f: 💔 Performance has regressed. time: [1.7915 ms 1.8040 ms 1.8165 ms]
change: [+1.4211% +2.1934% +2.9787%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [99.168 ns 99.453 ns 99.752 ns]
change: [+0.2198% +0.6792% +1.1706%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [118.37 ns 118.72 ns 119.10 ns]
change: [+0.6581% +1.5735% +2.3393%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: 💔 Performance has regressed. time: [118.04 ns 118.50 ns 119.06 ns]
change: [+1.0117% +2.6257% +5.3661%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [98.135 ns 98.284 ns 98.450 ns]
change: [-0.4789% +0.7807% +1.9058%] (p = 0.22 > 0.05)
RxStreamOrderer::inbound_frame(): 💔 Performance has regressed. time: [115.53 ms 115.59 ms 115.64 ms]
change: [+3.8280% +4.0390% +4.1720%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.4843 µs 5.6582 µs 5.8469 µs]
change: [-1.3856% +1.1943% +3.7670%] (p = 0.37 > 0.05)
transfer/pacing-false/varying-seeds: 💔 Performance has regressed. time: [43.809 ms 43.892 ms 43.989 ms]
change: [+4.8991% +5.2028% +5.5040%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: 💔 Performance has regressed. time: [44.118 ms 44.202 ms 44.293 ms]
change: [+4.9296% +5.1942% +5.4738%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: 💔 Performance has regressed. time: [43.867 ms 43.945 ms 44.036 ms]
change: [+4.8077% +5.0866% +5.4034%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: 💔 Performance has regressed. time: [43.889 ms 43.963 ms 44.040 ms]
change: [+4.1698% +4.4211% +4.6685%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: Change within noise threshold. time: [891.91 ms 901.57 ms 911.36 ms]
thrpt: [109.73 MiB/s 110.92 MiB/s 112.12 MiB/s]
change:
time: [+0.0451% +1.6539% +3.2647%] (p = 0.04 < 0.05)
thrpt: [-3.1615% -1.6270% -0.0451%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [302.83 ms 304.91 ms 307.06 ms]
thrpt: [32.567 Kelem/s 32.796 Kelem/s 33.022 Kelem/s]
change:
time: [-0.1388% +0.8404% +1.8094%] (p = 0.10 > 0.05)
thrpt: [-1.7772% -0.8334% +0.1390%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.204 ms 34.406 ms 34.631 ms]
thrpt: [28.876 elem/s 29.064 elem/s 29.237 elem/s]
change:
time: [-0.5783% +0.2941% +1.1259%] (p = 0.51 > 0.05)
thrpt: [-1.1133% -0.2932% +0.5817%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💔 Performance has regressed. time: [1.7109 s 1.7279 s 1.7453 s]
thrpt: [57.298 MiB/s 57.872 MiB/s 58.448 MiB/s]
change:
time: [+2.5789% +4.1383% +5.7202%] (p = 0.00 < 0.05)
thrpt: [-5.4107% -3.9739% -2.5140%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Signed-off-by: Lars Eggert <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>
|
@larseggert let me know once you want another review. |
Signed-off-by: Lars Eggert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In functions that return
ResultorOptionor where it is easy to make them do so w/o too many other code changes.This lets us enable the clippy
unwrap_usedcheck, which is a nice reminder not to be casual withunwrap.